react-dropdown-tree-select icon indicating copy to clipboard operation
react-dropdown-tree-select copied to clipboard

feat: Add new props for search, keyboard navigation, and scrolling

Open gandhis1 opened this issue 3 years ago • 3 comments

What does it do?

  • The new prop searchTerm can be used to set the initial search term or fully control the search semantics for a higher-order component.
  • The new prop onSearchChange allows specification of a callback for when the search term changes or the search mode is activated or deactivated.
  • The new prop disableKeyboardNavigation allows disabling all actions associated with a key down event in the search input box. This is important if you need an input box to behave normally. For instance, when I press SHIFT+HOME, it should select the entire line, so I can press BACKSPACE to clear it.
  • The new prop pageSize can be used to control the size of the scroll view before scrolling to near the bottom is required to show more nodes.

Fixes # (issue)

Fixes https://github.com/dowjones/react-dropdown-tree-select/issues/581 Requested https://github.com/dowjones/react-dropdown-tree-select/discussions/463 Fixes https://github.com/dowjones/react-dropdown-tree-select/issues/576

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

  • [X] I have performed a self-review of my own code
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] Updated documentation (if applicable)
  • [ ] Added tests that prove my fix is effective or that my feature works
  • [X] New and existing unit tests pass locally with my changes
  • [X] My changes generate no new warnings

gandhis1 avatar Aug 06 '22 19:08 gandhis1

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 02 '22 22:10 github-actions[bot]

Bump

gandhis1 avatar Oct 02 '22 23:10 gandhis1

Hello! Curious on the status of this pr, this change would help out my use case of not clearing the search term on selection.

Thanks!

charleslee94 avatar Feb 15 '23 18:02 charleslee94