react-dropdown-tree-select icon indicating copy to clipboard operation
react-dropdown-tree-select copied to clipboard

Convert remaining components to functional components

Open m4theushw opened this issue 5 years ago • 3 comments

What does it do?

  • Pulls all commits from develop and applies into hooks branch.
  • Converts all class components to functional components.
  • Fixes tests to work with hooks.

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] Updated documentation (if applicable)
  • [x] Added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] My changes generate no new warnings

m4theushw avatar Feb 12 '21 00:02 m4theushw

Pull Request Test Coverage Report for Build 1533

  • 164 of 167 (98.2%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 94.541%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tree/index.js 29 32 90.63%
<!-- Total: 164 167
Totals Coverage Status
Change from base Build 1507: 0.5%
Covered Lines: 669
Relevant Lines: 688

💛 - Coveralls

coveralls avatar Feb 12 '21 00:02 coveralls

This is awesome work @m4theushw !! Thanks for sending this. I'm gonna go over it this weekend and having the long weekend helps.

This is the first step towards having headless components and I'm glad we're heading in that direction.

mrchief avatar Feb 12 '21 22:02 mrchief

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 01 '21 22:12 github-actions[bot]