react-native-track-player icon indicating copy to clipboard operation
react-native-track-player copied to clipboard

[Feature Request] React Native New Architecture Update

Open mycloudvip opened this issue 1 year ago • 12 comments

It would be amazing to have this project fully compliant with the new architecture.

Kinds regards.

mycloudvip avatar Jan 01 '25 15:01 mycloudvip

@mycloudvip Made it compliant on android only with this fork (RN 0.76.6): https://github.com/praisedavid787/react-native-track-player/tree/feat/turbomodule.

praisedavid787 avatar Jan 28 '25 09:01 praisedavid787

Could be nice to integrate that asap to a new version!

rdhox avatar Feb 10 '25 15:02 rdhox

@rdhox I've added iOS support now. Was quite the hack but my project needs the new arch and I just had to go the extra mile.

praisedavid787 avatar Mar 28 '25 21:03 praisedavid787

@rdhox I've added iOS support now. Was quite the hack but my project needs the new arch and I just had to go the extra mile.

how to use your package , i am still getting error, i download your update repo and paste into node modules ? is this correct way to do it?

abdulragib avatar Apr 02 '25 16:04 abdulragib

No actually, I’ll send you a setup. Gimme a minute.

On Wed, 2 Apr 2025 at 17:41, Abdul Ragib @.***> wrote:

@rdhox https://github.com/rdhox I've added iOS support now. Was quite the hack but my project needs the new arch and I just had to go the extra mile.

how to use your package , i am still getting error, i download your update repo and paste into node modules ? is this correct way to do it?

— Reply to this email directly, view it on GitHub https://github.com/doublesymmetry/react-native-track-player/issues/2425#issuecomment-2773149726, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMI66NBYF2MFRY7MP2GFSDT2XQHJ7AVCNFSM6AAAAABUOXWY6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZTGE2DSNZSGY . You are receiving this because you commented.Message ID: @.*** com> [image: abdulragib]abdulragib left a comment (doublesymmetry/react-native-track-player#2425) https://github.com/doublesymmetry/react-native-track-player/issues/2425#issuecomment-2773149726

@rdhox https://github.com/rdhox I've added iOS support now. Was quite the hack but my project needs the new arch and I just had to go the extra mile.

how to use your package , i am still getting error, i download your update repo and paste into node modules ? is this correct way to do it?

— Reply to this email directly, view it on GitHub https://github.com/doublesymmetry/react-native-track-player/issues/2425#issuecomment-2773149726, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMI66NBYF2MFRY7MP2GFSDT2XQHJ7AVCNFSM6AAAAABUOXWY6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZTGE2DSNZSGY . You are receiving this because you commented.Message ID: @.*** com>

praisedavid787 avatar Apr 03 '25 19:04 praisedavid787

Could you please send me as well?

SaifulAzam avatar May 18 '25 00:05 SaifulAzam

I must say, not making the package complaint with the new Architecture, basically sunsets the entire package.

tsipho avatar Jun 06 '25 17:06 tsipho

@SaifulAzam @abdulragib sorry this is coming late. The setup is here https://github.com/doublesymmetry/react-native-track-player/issues/2443#issuecomment-2777240477. Feel free to reach out to me via my email if you encounter any issues.

praisedavid787 avatar Jun 06 '25 18:06 praisedavid787

this lib is practically abandoned unless maintenance is actually transferred to someone else with more time.

A couple of people forked. A handful of OSS apps even are released with newarch. the usage is stupidly simple. the sad truth of OSS is they dont make money and people lose interest over time. instead of whining ppl should fork and DIY.

lovegaoshi avatar Jun 07 '25 14:06 lovegaoshi

It's still maintained with new arch support planned for later this year according to @jspizziri https://github.com/doublesymmetry/react-native-track-player/issues/2467#issuecomment-2930351080

tobyt42 avatar Jun 07 '25 14:06 tobyt42

yeah good luck on that.

On Sat, Jun 7, 2025, 7:50 AM Toby T @.***> wrote:

tobyt42 left a comment (doublesymmetry/react-native-track-player#2425) https://github.com/doublesymmetry/react-native-track-player/issues/2425#issuecomment-2952597656

It's still maintained with new arch support planned for later this year according to @jspizziri https://github.com/jspizziri #2467 (comment) https://github.com/doublesymmetry/react-native-track-player/issues/2467#issuecomment-2930351080

— Reply to this email directly, view it on GitHub https://github.com/doublesymmetry/react-native-track-player/issues/2425#issuecomment-2952597656, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZMOVVUHU4TSVKRZHHMNE5L3CL34PAVCNFSM6AAAAABUOXWY6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNJSGU4TONRVGY . You are receiving this because you commented.Message ID: @.*** com>

lovegaoshi avatar Jun 07 '25 14:06 lovegaoshi

this lib is practically abandoned unless maintenance is actually transferred to someone else with more time.

A couple of people forked. A handful of OSS apps even are released with newarch. the usage is stupidly simple. the sad truth of OSS is they dont make money and people lose interest over time. instead of whining ppl should fork and DIY.

Sorry for this stupid question, but I see you doing a lot of stuff in your fork of this lib. Are you interested in publishing and maintaining the fork of this lib or is it something which is too timeconsuming? I Think A LOT of people would love to see a maintained fork of this lib instead of everyone cooking their own soup.

Blackfaded avatar Jun 16 '25 07:06 Blackfaded

time and money friend, npm download counts wont feed my stomach.

I expressed interest in taking over this lib when facebook suggested deprecating newarch headlessJS support seeing this lib is unmaintained. now its not a concern and i have better things to do than farming internet karma.

On Mon, Jun 16, 2025, 12:34 AM René Heinen @.***> wrote:

Blackfaded left a comment (doublesymmetry/react-native-track-player#2425) https://github.com/doublesymmetry/react-native-track-player/issues/2425#issuecomment-2975416487

this lib is practically abandoned unless maintenance is actually transferred to someone else with more time.

A couple https://github.com/lovegaoshi/react-native-track-player of https://github.com/lyswhut/react-native-track-player people https://github.com/weights-ai/react-native-track-player forked. A https://github.com/Jellify-Music/App handful https://github.com/lovegaoshi/azusa-player-mobile of OSS apps even are released with newarch. the usage is stupidly simple https://github.com/lovegaoshi/azusa-player-mobile/blob/89bd84d588caa8f5825738e5ce0c73f825eb3ca4/package.json#L129. the sad truth of OSS is they dont make money and people lose interest over time. instead of whining ppl should fork and DIY.

Sorry for this stupid question, but I see you doing a lot of stuff in your fork of this lib. Are you interested in publishing and maintaining the fork of this lib or is it something which is too timeconsuming? I Think A LOT of people would love to see a maintained fork of this lib instead of everyone cooking their own soup.

— Reply to this email directly, view it on GitHub https://github.com/doublesymmetry/react-native-track-player/issues/2425#issuecomment-2975416487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZMOVVR4K74SUKSXEMS2A7L3DZXQVAVCNFSM6AAAAABUOXWY6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNZVGQYTMNBYG4 . You are receiving this because you commented.Message ID: @.*** com>

lovegaoshi avatar Jun 16 '25 12:06 lovegaoshi

My employer might be willing to sponsor some of this work if it will help the maintainers.

subvertallchris avatar Jun 18 '25 18:06 subvertallchris

@subvertallchris we had sponsored DoubleSymmetry for a couple of years, but they've not responded to any of our inquiries about the status of the project for the past year. We are grateful for all of the work that went in to RNTP, but I'd recommend you proceed with caution if considering a sponsorship given the radio silence.

brianlenz avatar Jun 18 '25 18:06 brianlenz

@brianlenz good to know, thank you. The forceful tone of the last comment in #2443 suggested they were eager to move things along so I was optimistic. Hopefully things turn around.

subvertallchris avatar Jun 18 '25 19:06 subvertallchris

Initial implementation of newArch has been added via https://github.com/doublesymmetry/react-native-track-player/pull/2478/commits/5ce841270943a97b529ac1540c5c028413e0475b on this PR. https://github.com/doublesymmetry/react-native-track-player/pull/2478

The PR itself is quite large and also contains the media3 migration which has been in the works for a while.

My current plan is to release a 5.0.0-alpha.0 so folks can hammer on it and start providing feedback. I'd be interested in feedback on the PR as it exists now however if anyone wants to test.

jspizziri avatar Jun 25 '25 13:06 jspizziri

That's amazing, thank you @jspizziri! We will be testing and integrating as we are able in the coming weeks...

brianlenz avatar Jun 25 '25 16:06 brianlenz

@praisedavid787 just wanted to thank you for your work on newArch, it was definitely a helpful reference for me when implementing it on top of the media3 work. Would love your feeback on the PR referenced here https://github.com/doublesymmetry/react-native-track-player/issues/2425#issuecomment-3004817976

jspizziri avatar Jun 25 '25 20:06 jspizziri

@praisedavid787 kudos to you and the team, I'm also looking forward to test it!

mycloudvip avatar Jun 25 '25 20:06 mycloudvip

Just tried PR https://github.com/doublesymmetry/react-native-track-player/pull/2478 on new architecture, works like a charm from the first try 😍

tux2nicolae avatar Jun 27 '25 19:06 tux2nicolae

Can't wait to try it!!!! Kudos for ALL the great effort!!!

mycloudvip avatar Jun 27 '25 19:06 mycloudvip

Thanks so much @jspizziri and @mycloudvip — really appreciate the kind words! 🙏 Glad the newArch work proved helpful, and I’m excited to see how it integrates with the media3 effort. I’ll take a close look at the PR and drop my thoughts as soon as I can. Thanks again for pushing this forward — great to see the momentum!

praisedavid787 avatar Jun 27 '25 20:06 praisedavid787

First of all, thank you for your work on creating and maintaining this library — it’s greatly appreciated.

Over the past few weeks, Google Play has been showing a critical warning regarding the requirement to update the minimum target SDK to 35 before August 31st. This update appears to be tied to React Native v0.76.x and the adoption of the new architecture.

I was wondering if there’s any chance the pull request related to the new architecture could be merged or published in the coming weeks. It would be extremely helpful for those of us trying to comply with the new Play Store requirements.

Thanks again, and let me know if there’s anything I can do to help with testing or review.

ximomompo avatar Jul 16 '25 08:07 ximomompo

@ximomompo , you can update to the latest react-native version provided you disable newArch in your project.

jspizziri avatar Jul 16 '25 12:07 jspizziri

@jspizziri Thanks!

rdhox avatar Jul 25 '25 06:07 rdhox

@ximomompo to satisfy the policy, you can keep compileSdkVersion < 35 and set targetSdkVersion to 35 as long as you've tested it on a phone/simulator running SDK 35. You can also request an extension until October via a button on the policy alert in the Play Console.

azlyth avatar Aug 08 '25 04:08 azlyth

v5.0.0-alpha0 has just been released, which adds newArch support.

jspizziri avatar Aug 12 '25 13:08 jspizziri

Huge news, fantastic work! Thank you!

subvertallchris avatar Aug 12 '25 13:08 subvertallchris

On iOS I'm getting now 'new NativeEventEmitter()' requires a non null argument. I could look into it if needed or this is known issue right now?

AskoK avatar Aug 13 '25 20:08 AskoK