winforms icon indicating copy to clipboard operation
winforms copied to clipboard
verified publisher icon dotnet

[Accessibility] HC and default themes: The color contrast of checkmark in MenuStrip is less than 3:1

Open Olina-Zhang opened this issue 3 years ago • 9 comments

.NET version

8.0.100-alpha.1.22451.15

Did it work in .NET Framework?

Yes

Did it work in any of the earlier releases of .NET Core or .NET 5+?

No

Issue description

The color contrast of checkmark in MenuStrip is less than 3:1 on Windows 11 high contrast themes and Windows 10 some themes.

Windows 11 HC themes testing result: image

Windows 11 and Windows 10 default themes: image

Windows 10 HC themes testing result: image

Steps to reproduce

Sample application: WinFormsApp10.zip

Olina-Zhang avatar Sep 02 '22 07:09 Olina-Zhang

This is one we should address for .NET 8, if we can't meet min contrast for regular themes in HC themes then there is a problem. @Tanya-Solyanik what do you think about switching from green to a regular black or associated color?

merriemcgaw avatar Sep 07 '22 00:09 merriemcgaw

@Olina-Zhang - this does not work on .NET Framework on Win11 22H2 - I don't see checkmarks in any contrast or regular themes. Could you please confirm that this is a regression between the windows versions? @merriemcgaw - if this is a regression between the windows versions, we should consider servicing it in the framework.

no checkmark in contrast theme on .NET Framework

no checkmark in standard theme on .NET Framework

Tanya-Solyanik avatar Sep 17 '22 06:09 Tanya-Solyanik

@dreddy-work - we need a new icon to fix this issue, who should we work with, do you remember? - https://github.com/dotnet/winforms/blob/main/src/System.Windows.Forms/src/Resources/System/Windows/Forms/Checked.ico

Tanya-Solyanik avatar Sep 17 '22 07:09 Tanya-Solyanik

Would we engage https://aka.ms/d3triage?

RussKie avatar Sep 19 '22 03:09 RussKie

@Tanya-Solyanik cannot repro this issue in .Net framework 4.8.1 app: Default theme: image Win11 HC themes: image

Olina-Zhang avatar Sep 19 '22 07:09 Olina-Zhang

@Olina-Zhang - I have an insider preview from ni_release -

Version 22H2 Installed on ‎9/‎2/‎2022 OS build 22622.598 Experience Windows Feature Experience Pack 1000.22634.1000.0

Tanya-Solyanik avatar Sep 19 '22 07:09 Tanya-Solyanik

@Tanya-Solyanik we use the higher version than yours, do you have a HDPI machine setting? If so, you need to add HDPI support in app.config file, then will see that checkmark for toolStripMenuItem. image

Olina-Zhang avatar Sep 19 '22 10:09 Olina-Zhang

Ticket #17567 created: Checkmark icon for checked menu items.

Tanya-Solyanik avatar Sep 20 '22 04:09 Tanya-Solyanik

@dmitrii-drobotov - please assign this bug to someone on your team. This icon might not work in win10, or in selected state. It should be tested thoroughly in different states, win10 and win11 Contrast modes. Gray Check Mark From the US team

Tanya-Solyanik avatar Oct 03 '22 18:10 Tanya-Solyanik

Verified with .NET SDK 8.0.100-alpha.1.22527.5 build from main branch, this issue is fixed. Now the color contrast of checkmarks in MenuStrip is higher than 3:1 on Windows 11 high contrast themes： image image image image

Ashley-Li avatar Oct 28 '22 07:10 Ashley-Li