winforms
winforms copied to clipboard
Make the toolbar menu items support the support space key.
Fixes #11449
Proposed changes
- Modify the ProcessCmdKey() method to support space key.
- Make a focus on the MenuStrip after the user hits enter to check it.
Customer Impact
- MenuItems does not respond to the spacebar key to check/uncheck the menu and enter key executes it and closes the menu without focus the menustrip.
Regression?
- No
Risk
-Minimal
Screenshots
Before
After
Test methodology
- Manual
Test environment(s)
- 9.0.100-preview.6.24312.9
Microsoft Reviewers: Open in CodeFlow
Codecov Report
Attention: Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.
Project coverage is 74.56175%. Comparing base (
fc56416) to head (d2966bf). Report is 83 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #11520 +/- ##
===================================================
+ Coverage 74.39859% 74.56175% +0.16316%
===================================================
Files 3032 3041 +9
Lines 628149 629780 +1631
Branches 46828 46845 +17
===================================================
+ Hits 467334 469575 +2241
+ Misses 157465 156843 -622
- Partials 3350 3362 +12
| Flag | Coverage Δ | |
|---|---|---|
| Debug | 74.56175% <65.38462%> (+0.16316%) |
:arrow_up: |
| integration | 17.87556% <3.84615%> (-0.12500%) |
:arrow_down: |
| production | 47.45164% <65.38462%> (+0.20467%) |
:arrow_up: |
| test | 96.97796% <ø> (+0.01124%) |
:arrow_up: |
| unit | 44.55491% <65.38462%> (+0.32596%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
All LGTM