winforms icon indicating copy to clipboard operation
winforms copied to clipboard

Add property "AllowThousandsSeparatorInput" to control whether thousands separator can be entered in NumericUpdown

Open LeafShi1 opened this issue 1 year ago • 2 comments

Fixes #10908

Proposed changes

  • Add property "AllowThousandsSeparatorInput" to control NumericUpdown

Customer Impact

  • Whether Thousands Separator can be typed can be set through properties

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

The thousands separator "," can be entered in control "NumericUpdown" even if ThousandsSeparator is false

After

Whether Thousands Separator can be entered can be set through properties AfterChange

Test methodology

  • Manually (interactive test)

Test environment(s)

  • .net 9.0.0-preview.3.24154.1
Microsoft Reviewers: Open in CodeFlow

LeafShi1 avatar Mar 05 '24 09:03 LeafShi1

Codecov Report

Attention: Patch coverage is 2.85714% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 73.16878%. Comparing base (7ba25c5) to head (8c740ec). Report is 12 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10995         +/-   ##
===================================================
+ Coverage   73.13074%   73.16878%   +0.03803%     
===================================================
  Files           3097        3097                 
  Lines         633955      633989         +34     
  Branches       47364       47364                 
===================================================
+ Hits          463616      463882        +266     
+ Misses        166783      166556        -227     
+ Partials        3556        3551          -5     
Flag Coverage Δ
Debug 73.16878% <2.85714%> (+0.03803%) :arrow_up:
integration 18.44709% <11.11111%> (+0.08633%) :arrow_up:
production 46.67137% <11.11111%> (+0.09200%) :arrow_up:
test 94.96744% <0.00000%> (-0.00740%) :arrow_down:
unit 43.57199% <11.11111%> (+0.03162%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Mar 05 '24 10:03 codecov[bot]

@LeafShi1 - we'll re-triage this issue

Tanya-Solyanik avatar Mar 05 '24 20:03 Tanya-Solyanik

we had re-triaged the bug, closing this PR.

Tanya-Solyanik avatar Mar 19 '24 18:03 Tanya-Solyanik