winforms icon indicating copy to clipboard operation
winforms copied to clipboard

Add hollow types for deprecated UI controls

Open SimonZhao888 opened this issue 1 year ago • 10 comments

Fixes #3783

Proposed changes

  • Add Controls removed in NET3.1 Back to .NET10 for binary compatibility
  • Throw PlatformNotSupportedException exceptions in public methods and properties of the deprecated controls
  • Restore previously removed properties on the existing controls
  • Add [Browsable(false), EditorBrowsable(EditorBrowsableState.Never)] attributes to all the public properties.
  • Add [Obsolete("*** is not supported. Use *** instead.")] attribute to all re-added controls

Test methodology

  • manually
  • added a case to the integration test - WinformsControlTest

Test environment(s)

  • 9.0.0-preview.2.24120.8
Microsoft Reviewers: Open in CodeFlow

SimonZhao888 avatar Feb 20 '24 06:02 SimonZhao888

Codecov Report

Attention: Patch coverage is 1.66521% with 1122 lines in your changes missing coverage. Please review.

Project coverage is 73.31842%. Comparing base (6710618) to head (cf386e6). Report is 532 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10913         +/-   ##
===================================================
- Coverage   73.44496%   73.31842%   -0.12654%     
===================================================
  Files           3097        3122         +25     
  Lines         632155      633362       +1207     
  Branches       46653       46660          +7     
===================================================
+ Hits          464286      464371         +85     
- Misses        164469      165597       +1128     
+ Partials        3400        3394          -6     
Flag Coverage Δ
Debug 73.31842% <1.66521%> (-0.12654%) :arrow_down:
integration 18.30607% <0.00000%> (-0.05976%) :arrow_down:
production 46.76045% <0.00000%> (-0.15391%) :arrow_down:
test 94.93400% <8.96226%> (-0.05098%) :arrow_down:
unit 43.73995% <0.00000%> (-0.14366%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Mar 11 '24 07:03 codecov[bot]

LGTM

ricardobossan avatar Apr 09 '24 10:04 ricardobossan