vscode-csharp icon indicating copy to clipboard operation
vscode-csharp copied to clipboard
verified publisher icon dotnet

Adding changes to support use monovsdbg to debug wasm apps.

Open thaystg opened this issue 1 year ago • 7 comments

Adding changes to support debug wasm apps using monovsdbg.

image

Tested scenarios with the new setting enabled and this PR:

  • With Assets and C# DevKit Not Installed targetting .NET 8 (Blazor Wasm) - DISABLED

  • With Assets and C# DevKit Not Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED

  • With Assets and C# DevKit Not Installed targetting .NET 9 (Blazor Wasm) - ENABLED

  • With Assets and C# DevKit Not Installed targetting .NET 9 (Blazor Server Wasm) - ENABLED

  • With Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) - DISABLED

  • With Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED

  • With Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) - ENABLED

  • With Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) - ENABLED

  • Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) - DISABLED

  • Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED

  • Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) - ENABLED

  • Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) - ENABLED

Tested scenarios only updating C# DevKit with the monovsdbg support:

  • Without Assets and C# DevKit Installed with C# extension without this PR targetting .NET 8 (Blazor Wasm) - DISABLED
  • Without Assets and C# DevKit Installed with C# extension without this PR targetting .NET 8 (Blazor Server Wasm) - DISABLED
  • Without Assets and C# DevKit Installed with C# extension without this PR targetting .NET 9 (Blazor Wasm) - DISABLED
  • Without Assets and C# DevKit Installed with C# extension without this PR targetting .NET 9 (Blazor Server Wasm) - DISABLED

Tested scenarios with this PR and C# DevKit without the monovsdbg support:

  • With Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) - DISABLED

  • With Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED

  • With Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) - ENABLED

  • With Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) - ENABLED

  • Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) - DISABLED

  • Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED

  • Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) - DISABLED

  • Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) - DISABLED

thaystg avatar Jun 10 '24 16:06 thaystg

@gregg-miskelly can you please review again? I think I addressed all your comments.

thaystg avatar Jun 28 '24 05:06 thaystg

@gregg-miskelly I think I'm done again. If you can review it will be great.

thaystg avatar Jul 08 '24 19:07 thaystg

Did you want to update a case for the updatePackageDependencies script?

https://github.com/dotnet/vscode-csharp/blob/602cd792949d79d86333fa5cadad0aa1f3b8eb08/src/tools/updatePackageDependencies.ts#L276

WardenGnaw avatar Jul 15 '24 20:07 WardenGnaw

Did you want to update a case for the updatePackageDependencies script?

https://github.com/dotnet/vscode-csharp/blob/602cd792949d79d86333fa5cadad0aa1f3b8eb08/src/tools/updatePackageDependencies.ts#L276

I'm using npm run updatePackageDependencies to update the webassembly package but I didn't need to change this file.

thaystg avatar Jul 16 '24 13:07 thaystg

@thaystg Is this still a change we want to consider?

JoeRobich avatar Feb 06 '25 22:02 JoeRobich

Correct, we will work on it yet, but I will mark it as a draft for now.

thaystg avatar Feb 07 '25 13:02 thaystg

Can I get a review again here?

thaystg avatar Aug 08 '25 13:08 thaystg