try icon indicating copy to clipboard operation
try copied to clipboard

Sizing issues of the IFrame containing the interactive editor

Open ocallesp opened this issue 1 year ago • 9 comments

image

This is needed in order to improve the UI.

In production it looks seamless image

however with the new version we can see some unnecessary overflow image

ocallesp avatar May 23 '24 00:05 ocallesp

Additional context: this is specific to the marketing page.

AbhitejJohn avatar May 23 '24 00:05 AbhitejJohn

https://dotnetwebsite.azurewebsites.net/en-us/

or for pr changes

https://dotnetwebsite-dev-pr-6496.azurewebsites.net/

ocallesp avatar May 23 '24 16:05 ocallesp

The editor can be found here: https://dotnet.microsoft.com/en-us/languages

jonsequitur avatar Jun 03 '24 19:06 jonsequitur

The fix should go in the host

ocallesp avatar Jun 04 '24 17:06 ocallesp

The element that needs to be sized is here: image

It should be sized using the Monaco API, which is exposed by trydotnet.js.

jonsequitur avatar Jun 04 '24 19:06 jonsequitur

@jonsequitur can you point me to the Monaco API for sizing?

danzhu54 avatar Jun 10 '24 16:06 danzhu54

https://microsoft.github.io/monaco-editor/typedoc/interfaces/editor.IEditor.html#layout.layout-1

jonsequitur avatar Jun 10 '24 18:06 jonsequitur

When does the editor set the size by default? It seems to be called twice: once when it initializes and then again when I set the size with setSize image

Is it possible for me to pass in my size preferences to the editor via createSessionWithProjectAndOpenDocument?

danzhu54 avatar Jun 11 '24 00:06 danzhu54

@danzhu54 you cannot pass the size of the editor via createSessionWithProjectAndOpenDocument

ocallesp avatar Jun 14 '24 00:06 ocallesp