dotnet
FV changes
We are excited to review your PR.
So we can do the best job, please check:
- [ ] There's a descriptive title that will make sense to other developers some time from now.
- [ ] There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format
Fixes #nnnnin your description to cause GitHub to automatically close the issue(s) when your PR is merged. - [ ] Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
- [ ] You have included any necessary tests in the same PR.
Hi @mansijain52, are you still working on this?
Yes. We are done with changes. Waiting to get this merged
@mansijain52 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@dotnet-policy-service agree [company="{your company}"]Options:
- (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
- (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"Contributor License Agreement
@dotnet-policy-service agree company="Microsoft"
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @mansijain52, please resolve your conflicts and proceed with this PR, thanks!
Yes. I will complete it this week
On Wed, 26 Feb, 2025, 09:50 Dan Wu, @.***> wrote:
Hi @mansijain52 https://github.com/mansijain52, will you continue work on this?
— Reply to this email directly, view it on GitHub https://github.com/dotnet/spark/pull/1177#issuecomment-2683855831, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALRCDNQZJ4RDR6UMNHEEYG32RU6IXAVCNFSM6AAAAABIYAAKA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBTHA2TKOBTGE . You are receiving this because you were mentioned.Message ID: @.***> [image: wudanzy]wudanzy left a comment (dotnet/spark#1177) https://github.com/dotnet/spark/pull/1177#issuecomment-2683855831
Hi @mansijain52 https://github.com/mansijain52, will you continue work on this?
— Reply to this email directly, view it on GitHub https://github.com/dotnet/spark/pull/1177#issuecomment-2683855831, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALRCDNQZJ4RDR6UMNHEEYG32RU6IXAVCNFSM6AAAAABIYAAKA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBTHA2TKOBTGE . You are receiving this because you were mentioned.Message ID: @.***>
src\csharp\Microsoft.Spark\TaskContext.cs#L28
src\csharp\Microsoft.Spark\TaskContext.cs(28,22): error CS0102: (NETCORE_ENGINEERING_TELEMETRY=Build) The type 'TaskContext' already contains a definition for 'CPUs'
Maybe a conflict, because previous upgrades (3.3, 3.5) already added this field.
Maybe a conflict, because previous upgrades (3.3, 3.5) already added this field.
Updated
Commenter does not have sufficient privileges for PR 1177 in repo dotnet/spark
Hi @mansijain52, the spark 3.4 was already added and a new release was made. Please check if that already meets your need.