sdk icon indicating copy to clipboard operation
sdk copied to clipboard
verified publisher icon dotnet

Improve the example with specified language when language option is given with invalid option

Open GangWang01 opened this issue 3 years ago • 1 comments

Problem

  • https://github.com/dotnet/templating/issues/4494
  • When valid bool option and invalid option are given, the exception unable to cast is thrown .
  • Cli lacks unit tests for the option with invalid names.

Solution

  • Specified language is added to the example when language option is given together with invalid option.
  • Handle bool option in TemplateOptionResult for handling no template found
  • Expand Cli unit tests.

Checks:

  • [x] Added unit tests
  • [ ] Added #nullable enable to all the modified files ?

GangWang01 avatar Sep 23 '22 15:09 GangWang01

Agreed to retarget to 7.0.2xx.

vlada-shubina avatar Sep 27 '22 14:09 vlada-shubina

Retargeted to 7.0.2xx

vlada-shubina avatar Oct 04 '22 11:10 vlada-shubina

@JanKrivanek I accidently removed you from reviewers. Please take a look if you have time.

GangWang01 avatar Oct 10 '22 03:10 GangWang01