sdk icon indicating copy to clipboard operation
sdk copied to clipboard

Passing properties with multiple values stops woring with net7 RC1 - 7.0.100-rc.1.22431.12

Open noxe opened this issue 3 years ago • 10 comments

Issue Description

Hi - in our csproj files use use custom properties for additional AssemblySearchPaths, see below where we added $(ReferencePath).

<AssemblySearchPaths>$(AssemblySearchPaths);$(ReferencePath);$(OutputPath);$(OutputPath)\Server</AssemblySearchPaths>

Now we start a build an pass in the ReferencePath:

dotnet.exe build test.sln --configuration Release /property:ReferencePath="C:\123;C:\456"

with NET6 - when doing an verbose build - we get this:

     SearchPaths:
         {CandidateAssemblyFiles}
         {HintPathFromItem}
         {TargetFrameworkDirectory}
         {RawFileName}
         C:\123
         C:\456

now with NET7 RC1 SDK - we get this:

     SearchPaths:
         {CandidateAssemblyFiles}
         {HintPathFromItem}
         {TargetFrameworkDirectory}
         {RawFileName}
         C:\123;C:\456

See the values are not split anymore - and the paths are not working? Any info about this behaviour?

thx

noxe avatar Sep 22 '22 18:09 noxe

Duplicate of dotnet/sdk#27059

rainersigwald avatar Sep 22 '22 18:09 rainersigwald

thx for the fast reply. I see this was fixed in 6.0.x - so will this com to 7.0.x ?

noxe avatar Sep 22 '22 19:09 noxe

@noxe Yes, I believe it'll be in RC2.

rainersigwald avatar Sep 22 '22 20:09 rainersigwald

thank you!

noxe avatar Sep 23 '22 05:09 noxe

So - i tested this with .NET SDK 6.0.401 - but this still does not work @rainersigwald:

"C:\Program Files\dotnet\sdk\6.0.401"

command:

dotnet build buildprop.sln -p:ReferencePath="c:\test;c:\test1"

or

dotnet build buildprop.sln -p:ReferencePath="c:\test,c:\test1"

does NOT split the paths:

     SearchPaths:
         {CandidateAssemblyFiles}
         {HintPathFromItem}
         {TargetFrameworkDirectory}
         {RawFileName}
         c:\test;c:\test1

noxe avatar Sep 23 '22 05:09 noxe

@noxe please report that in the SDK bug.

rainersigwald avatar Sep 23 '22 13:09 rainersigwald

Moving to the dotnet/sdk repo, as the semicolon-delimiting aspect of values is the particular regression here.

baronfel avatar Sep 23 '22 14:09 baronfel

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Apologies for this @noxe - we've got a PR up for this that we will work on including in a servicing fix for this series of SDKs and onwards.

baronfel avatar Sep 23 '22 14:09 baronfel

thx you for the Update!

noxe avatar Sep 24 '22 11:09 noxe

closing as the linked PRs are in.

baronfel avatar Jan 30 '24 20:01 baronfel