runtime Enable IDE0060 (Remove unused parameter) analyzer

Follow up on #67527 which was closed meantime

Jul 22 '22 08:07 marek-safar

Tagging subscribers to this area: @dotnet/area-meta See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	marek-safar
Assignees:	-
Labels:	`area-Meta`
Milestone:	-

Jul 22 '22 08:07 ghost

More violations to fix..

Aug 10 '22 21:08 danmoseley

@marek-safar do you plan to continue?

Sep 06 '22 02:09 danmoseley

Might be easiest to just merge some fixes at first and not attempt to get clean and enable the rule all in one PR

Sep 06 '22 02:09 danmoseley

just curious, are you using a fixer? presumably in theory you can click the button to fix all instances in the solution.

Sep 15 '22 19:09 danmoseley

presumably in theory you can click the button to fix all instances in the solution.

yeah, in theory

Sep 16 '22 11:09 marek-safar

@danmoseley @stephentoub PR is ready for review

Sep 19 '22 08:09 marek-safar

Failures are timeouts

Nov 08 '22 13:11 marek-safar

@marek-safar After this change I can no longer build locally. .\build.cmd clr+libs -rc checked -c release gives me tons of

C:\dev\dotnet\runtime\src\libraries\System.Private.CoreLib\src\System\Runtime\Intrinsics\Wasm\WasmBase.PlatformNotSupported.cs(36,49
): error IDE0060: Remove unused parameter 'value' [C:\dev\dotnet\runtime\src\coreclr\System.Private.CoreLib\System.Private.CoreLib.c
sproj]

Nov 08 '22 14:11 jakobbotsch

Looks like unlucky timing with #77777

Nov 08 '22 14:11 jakobbotsch

Looking...

Nov 08 '22 14:11 stephentoub