runtime icon indicating copy to clipboard operation
runtime copied to clipboard

[mono] [android] System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet fails

Open jkurdek opened this issue 1 year ago • 2 comments

android_arm64_release_allsubsets_mono. Also arm, x64, x86.

Stack trace

10-28 05:55:04.448 11762 11805 I DOTNET  : Failed tests:
10-28 05:55:04.448 11762 11805 I DOTNET  : 1) 	[FAIL] System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet   Test name: System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet
10-28 05:55:04.448 11762 11805 I DOTNET  :    Assembly:  [System.Net.NetworkInformation.Functional.Tests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]
10-28 05:55:04.448 11762 11805 I DOTNET  :    Exception messages: Assert.Equal() Failure: Strings differ
10-28 05:55:04.448 11762 11805 I DOTNET  : Expected: ""
10-28 05:55:04.448 11762 11805 I DOTNET  : Actual:   "localdomain"
10-28 05:55:04.448 11762 11805 I DOTNET  :            Γåæ (pos 0)   Exception stack traces:    at System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet() in /_/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs:line 215
10-28 05:55:04.448 11762 11805 I DOTNET  :    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
10-28 05:55:04.448 11762 11805 I DOTNET  :    at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Build Information

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=850434 Build error leg or test failing: System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: :mag_right: https://dev.azure.com/dnceng-public/public/_build/results?buildId=850434 Error message validated: [System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet] Result validation: :white_check_mark: Known issue matched with the provided build. Validation performed at: 10/28/2024 1:39:53 PM UTC

Report

Build Definition Test Pull Request
850434 dotnet/runtime System.Net.NetworkInformation.Tests.IPGlobalPropertiesTest.IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 1

jkurdek avatar Oct 28 '24 13:10 jkurdek

Tagging subscribers to 'arch-android': @vitek-karas, @simonrozsival, @steveisok, @akoeplinger See info in area-owners.md if you want to be subscribed.

Tagging subscribers to this area: @dotnet/ncl See info in area-owners.md if you want to be subscribed.

The range for regression is https://github.com/dotnet/runtime/compare/a09ad529...10ee2b11. Possibly related to https://github.com/dotnet/runtime/pull/107241, @wfurt could you please check it out?

matouskozak avatar Nov 15 '24 11:11 matouskozak

it is likely @matouskozak. At least the test was added there. It seems like Android injects something there. I guess one option would be to simply skip this test on Android. Any thoughts on this @simonrozsival ?

wfurt avatar Nov 16 '24 10:11 wfurt

@matouskozak @wfurt this seems to be the default value on Android. I am not sure if this is the default/fallback value in the bionic libc or if Android calls setdomainname("localdomain") and it is a valid value. I think we should just skip this test because Android.

simonrozsival avatar Nov 18 '24 12:11 simonrozsival

I look at the test again @antonfirsov and I think we should update the assert to expect the localdomain on Android. I think I would prefer that over disabling the test.

wfurt avatar Nov 21 '24 16:11 wfurt

Fixed in https://github.com/dotnet/runtime/pull/110070, thank you @antonfirsov

matouskozak avatar Dec 27 '24 08:12 matouskozak