msbuild icon indicating copy to clipboard operation
msbuild copied to clipboard

Proper support for multiline messages

Open MichalPavlik opened this issue 2 years ago • 3 comments

Fixes #9666

Context

Adding proper support for multiline messages (with indentation). Removed project name from message line.

Changes Made

Terminal logger uses different parsing and rendering.

Testing

Unit tests were updated + manual testing (Windows)

Notes

New output:

MSBuild version 17.10.0-dev-24101-01+36ab632fa for .NET Framework
  XUnitTestProject succeeded with warnings (0,2s)
    C:\TestProjects\XUnitTestProject\XUnitTestProject\XUnitTestProject.csproj(26,0): warning : 
      A
      Multi
      Line
      Warning.

MichalPavlik avatar Feb 01 '24 14:02 MichalPavlik

Oh, just had a thought about moving the first line: @baronfel that would break the VS Code problem matcher, wouldn't it?

rainersigwald avatar Feb 02 '24 16:02 rainersigwald

Oof, you're right. We'd need to check and update those

baronfel avatar Feb 02 '24 16:02 baronfel

I checked the matcher regex and it doesn't (for example) support all combinations we have for line/column info. For example case when lineNumber != 0 && columnNumber == 0 && endLineNumber != 0.

MichalPavlik avatar Feb 05 '24 13:02 MichalPavlik

/azp run

MichalPavlik avatar Mar 18 '24 12:03 MichalPavlik

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 18 '24 12:03 azure-pipelines[bot]

As discussed offline, we will not wait for VSCode update.

MichalPavlik avatar Mar 18 '24 14:03 MichalPavlik

@MichalPavlik the diff is now showing 277 modified files. Something didn't go well with rebase/merge.

ladipro avatar Mar 21 '24 13:03 ladipro

I had to rebase to register this feature. I'm not sure what happened, but these additional changes should reflect current main.

MichalPavlik avatar Mar 21 '24 13:03 MichalPavlik

I reconstructed commit stream on top of main, but it looks like I'm removing Jakub's changes for some reason....

MichalPavlik avatar Mar 21 '24 14:03 MichalPavlik