fsharp

fsharp copied to clipboard

`open type T` treated as unused when unqualified extension member on `T` used

1

See also #17619, but this issue applies to all types. **Repro steps** ```fsharp type T = static member A = 99 [] module M = type T with static member...

brianrourkeboll

Detect `open type` use correctly for enums

1

## Description Fixes #17619. - Consider `open type` used when the type is an enum and any of the enum cases is used unqualified. ## Checklist - [x] Test cases...

brianrourkeboll

Better error reporting for let bindings.

2

## Description Improve error reporting for Binding checking code bindings including let bindings, let-rec bindings, member bindings and object-expression bindings Fixes # (issue, if applicable) ## Checklist - [x] Test...

edgarfgp

Merge release/dev17.8 to release/dev17.9

1

This is an automatically generated pull request from release/dev17.8 into release/dev17.9. Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯...

dotnet-bot

Nullness - generated ToString() members should override object and return string WithoutNull

1

- Overriding .ToString on an F# type will warn if it returns nullable string - Calling .ToString on F# types with generated ToString (powered by sprintfn %A under the hood)...

T-Gro

Merge main to release/dev17.12

1

This is an automatically generated pull request from main into release/dev17.12. Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯...

dotnet-bot

`open type T` when `T` is an enum is treated as unused even when it's used

1

**Repro steps** ```fsharp // Shows as unused; the unused opens analyzer will suggest removing it. open type System.DayOfWeek // …Even though it's used. let monday = Monday ``` **Expected behavior**...

brianrourkeboll

Investigate.17607

1

I believe this fixes: https://github.com/dotnet/fsharp/issues/17607 But it introduces another bug that needs fixing.

KevinRansom

Fields and methods on internal types are impossible to make public

20

This is causing #2184 - I don't think the Roslyn EE is doing anything wrong here. ```f# module internal InternalModule = type DebugProxy() = member __.PublicMethod() = 15 member __.CustomGetter...

saul

Scoped #nowarn

1

## Description This is a draft PR (WiP) for a [scoped #nowarn](https://github.com/fsharp/fslang-suggestions/issues/278). ## Checklist - [X] implementation for impl files - [X] draft [RFC](https://github.com/fsharp/fslang-design/pull/782) - [X] implementation for sig files...

Martin521