fsharp icon indicating copy to clipboard operation
fsharp copied to clipboard
verified publisher icon dotnet

Fix or remove legacy VS tests

Open psfinaki opened this issue 1 year ago • 4 comments

CI is breaking for WindowsCompressedMetadata now.

psfinaki avatar Jun 20 '24 17:06 psfinaki

Please don't remove the salsa tests. They have saved me numerous times (and likely not only me 😁). Even though I didn't like to debug them, they were the only failing ones and caught some actual regressions.

auduchinok avatar Jun 20 '24 20:06 auduchinok

Please don't remove the salsa tests. They have saved me numerous times (and likely not only me 😁). Even though I didn't like to debug them, they were the only failing ones and caught some actual regressions.

They flaky, and start to fail all of the sudden. We will definitely remove them once we move out of process.

vzarytovskii avatar Jun 20 '24 20:06 vzarytovskii

They flaky, and start to fail all of the sudden. We will definitely remove them once we move out of process.

Would be nice to port at least the completion tests then.

auduchinok avatar Jun 20 '24 20:06 auduchinok

They flaky, and start to fail all of the sudden. We will definitely remove them once we move out of process.

Would be nice to port at least the completion tests then.

Not gonna port, there will be just different completion tests for lsp

vzarytovskii avatar Jun 20 '24 21:06 vzarytovskii