fsharp icon indicating copy to clipboard operation
fsharp copied to clipboard

Error when property has same name as DU case

Open edgarfgp opened this issue 1 year ago • 1 comments

Description

Fixes #16646

Checklist

  • [x] Test cases added

  • [ ] Performance benchmarks added in case of performance changes

  • [ ] Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation. Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

edgarfgp avatar Feb 24 '24 23:02 edgarfgp

:heavy_exclamation_mark: Release notes required

@edgarfgp,

[!CAUTION] No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md No release notes found or release notes format is not correct

github-actions[bot] avatar Feb 24 '24 23:02 github-actions[bot]

Seems like I have some unrelated tests failing. Failed TryGetRecentCheckResultsForFile called with snapshot returns cached result after ParseAndCheckFile(True) [240 ms] Error Message: System.Exception : no results from TryGetRecentCheckResultsForFile cc @vzarytovskii FYI

edgarfgp avatar Feb 26 '24 16:02 edgarfgp

Seems like we I have some unrelated tests failing. Failed TryGetRecentCheckResultsForFile called with snapshot returns cached result after ParseAndCheckFile(True) [240 ms] Error Message: System.Exception : no results from TryGetRecentCheckResultsForFile cc @vzarytovskii FYI

I have seen this one today as well. It's a transparent compiler tests, I will disable it and create an issue for re-enabling.

vzarytovskii avatar Feb 26 '24 16:02 vzarytovskii

https://github.com/dotnet/fsharp/issues/16766

vzarytovskii avatar Feb 26 '24 16:02 vzarytovskii