fsharp icon indicating copy to clipboard operation
fsharp copied to clipboard

Include SourceLink file in CoreCompile dependency checks

Open baronfel opened this issue 1 year ago • 1 comments

Description

A companion to dotnet/msbuild#9743 to ensure that more sourcelink/determinism-related flags correctly cause the compiler to be invoked when they change.

This causes the compile to be invoked in more scenarios where property that influence compilation change. See https://github.com/dotnet/sdk/issues/16325#issuecomment-1942524229 for full details on how this was found.

Checklist

  • [ ] Test cases added

  • [ ] Performance benchmarks added in case of performance changes

  • [ ] Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation. Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

baronfel avatar Feb 14 '24 21:02 baronfel

:white_check_mark: No release notes required

github-actions[bot] avatar Feb 14 '24 21:02 github-actions[bot]