fsharp icon indicating copy to clipboard operation
fsharp copied to clipboard

PrettyNaming: remove the extra checks in `AddBackticksToIdentifierIfNeeded`

Open auduchinok opened this issue 2 years ago • 7 comments

Tries to fix the normalization of identifiers like this one:

```foo`.``

auduchinok avatar Jan 30 '24 16:01 auduchinok

:heavy_exclamation_mark: Release notes required


:white_check_mark: Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

github-actions[bot] avatar Jan 30 '24 16:01 github-actions[bot]

Any tests here? :) I think we had something for pretty naming.

psfinaki avatar Feb 01 '24 14:02 psfinaki

I think we had something for pretty naming.

Could you point me to them, if you have an idea of where to look at, please?

auduchinok avatar Feb 01 '24 19:02 auduchinok

Mmm this I guess? 👀

psfinaki avatar Feb 02 '24 11:02 psfinaki

Tries to fix the normalization of identifiers like this one:


```foo`.``

Is this missing something or ready to merge?

vzarytovskii avatar Feb 29 '24 20:02 vzarytovskii

Is this missing something or ready to merge?

I think I should add some tests, as @psfinaki has suggested. Otherwise it should be good to go in.

auduchinok avatar Mar 04 '24 17:03 auduchinok

Converting to draft for the time being, since it is still missing the tests

abonie avatar May 06 '24 17:05 abonie