fsharp icon indicating copy to clipboard operation
fsharp copied to clipboard

[WIP] Tidy: simplify tuple info

Open charlesroddie opened this issue 2 years ago • 3 comments

Description

The type TupInfo was uncessary and not documented. It reduces to a bool (representing whether the tuple is a struct), allowing simplification of code. The uses of this bool are now documented as isStruct. A few methods can be simplified or deleted as a result.

NO_RELEASE_NOTES

charlesroddie avatar Jan 10 '24 08:01 charlesroddie

:heavy_exclamation_mark: Release notes required

@charlesroddie,

[!CAUTION] No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md No release notes found or release notes format is not correct

github-actions[bot] avatar Jan 10 '24 08:01 github-actions[bot]

I am doing something tiny in this PR to figure out the process again before doing something interesting.

Currently if I run build.cmd on my system on main I get

C:\Users\charl\source\repos\fsharp\buildtools\buildtools.targets(30,5): error MSB3073: The command ""C:\Program Files\d
otnet\dotnet.exe" "C:\Users\charl\source\repos\fsharp\artifacts\\Bootstrap\fslex\fslex.dll" -o "C:\Users\charl\source\r
epos\fsharp\artifacts\obj\FSharp.Compiler.Service\Debug\netstandard2.0\illex.fs" --module FSharp.Compiler.AbstractIL.As
ciiLexer --internal --open Internal.Utilities.Text.Lexing --open FSharp.Compiler.AbstractIL.AsciiParser --unicode --lex
lib Internal.Utilities.Text.Lexing AbstractIL\illex.fsl" exited with code 1. [C:\Users\charl\source\repos\fsharp\src\Co
mpiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]

charlesroddie avatar Jan 20 '24 22:01 charlesroddie

I am doing something tiny in this PR to figure out the process again before doing something interesting.

Currently if I run build.cmd on my system on main I get


C:\Users\charl\source\repos\fsharp\buildtools\buildtools.targets(30,5): error MSB3073: The command ""C:\Program Files\d

otnet\dotnet.exe" "C:\Users\charl\source\repos\fsharp\artifacts\\Bootstrap\fslex\fslex.dll" -o "C:\Users\charl\source\r

epos\fsharp\artifacts\obj\FSharp.Compiler.Service\Debug\netstandard2.0\illex.fs" --module FSharp.Compiler.AbstractIL.As

ciiLexer --internal --open Internal.Utilities.Text.Lexing --open FSharp.Compiler.AbstractIL.AsciiParser --unicode --lex

lib Internal.Utilities.Text.Lexing AbstractIL\illex.fsl" exited with code 1. [C:\Users\charl\source\repos\fsharp\src\Co

mpiler\FSharp.Compiler.Service.fsproj::TargetFramework=netstandard2.0]

Hard to tell what's wrong, please run detailed build or collect the binlog, it should show whole error

vzarytovskii avatar Jan 22 '24 08:01 vzarytovskii