dotnet
Spelling
As discussed in #16204
Fixes misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/fsharp/actions/runs/6720404664/attempts/1#summary-18263884401
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/fsharp/actions/runs/6720404656/attempts/1#summary-18263884386
Damn... did not think it would be that bad :D Hey do you think we could have these changes in chunks? Like, 100-150 in each so that this is more manageable to review? We could go by projects or folders.
Hey do you think we could have these changes in chunks?
please no, it will kill git history, this way we only need to ignore one revision.
Damn... did not think it would be that bad :D
For a project of this size, it's about as I'd expect (larger projects can get to ~1k commits).
I'm on an m1 mac and can't figure out how to run the UpdateXlf thing. I have a mono, but that didn't help.
https://visualstudio.microsoft.com/vs/preview/#download-preview offers me an .exe which seems unhelpful on Darwin/macOS...
I'm tempted to just punt on the changes related to this.
Ran xlf: https://github.com/dotnet/fsharp/actions/runs/6732262393
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
BTW I think VS Code PR extension is doing much better job in reviewing and commenting on PRs of this size. I have switched to that :)
@psfinaki: I'd love to be able to talk via Slack, but the Join the F# Software Foundation flow yields a 400...
@jsoref meanwhile you can join Discord if that's an option for you: https://discord.com/invite/fsharp-196693847965696000
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
@psfinaki: do you want me to resolve conflicts, or will you do that when you work on fixing up the tests?
@jsoref the tests should be fixed as of now, main has a working version. Just merge or rebase - whatever your workflow here is.
:warning: Release notes required, but author opted out
[!WARNING] Author opted out of release notes, check is disabled for this pull request. cc @dotnet/fsharp-team-msft
ok. I believe that all tests now pass which means it's time to decide how to slice this.
The most naive slicing would be by directory. Assuming (and I haven't checked) that the following are relatively independent, I could probably group these 4 directories together as a single reviewable lump (this is by commits, not files changed, but in general commits roughly map by scale to files changed):
3 fcs-samples/
8 scripts/
11 docs/
18 buildtools/
These exceed what'd be reasonable to review for a 150 changeset threshold:
186 src/
324 vsintegration/
342 tests/
possible slicing strategy by commits by directory
This set of things could probably be lumped together, minus the concern that tests tend to correspond to src -- note that my general approach to peeling is to drop any commit that spans outside my scope, so if a changeset touches both tests and src, I'd drop it, and leave it for a later PR -- this means I don't have to worry too much about CI failing as I slice...
1 src/LegacyMSBuildResolver/
1 src/fsi/
1 tests/AheadOfTime/
1 tests/FSharp.Build.UnitTests/
1 tests/FSharp.Compiler.Service.Tests/
1 tests/walkthroughs/
2 src/Microsoft.FSharp.Compiler/
2 vsintegration/ProjectTemplates/
3 tests/FSharp.Test.Utilities/
4 src/FSharp.DependencyManager.Nuget/
4 tests/FSharp.Compiler.Private.Scripting.UnitTests/
4 tests/FSharp.Compiler.UnitTests/
7 tests/benchmarks/
7 tests/scripts/
21 tests/EndToEndBuildTests/
22 tests/FSharp.Core.UnitTests/
33 src/FSharp.Core/
39 tests/service/
Again, these are probably too large to review:
93 tests/fsharpqa/
112 vsintegration/tests/
115 tests/FSharp.Compiler.ComponentTests/
139 tests/fsharp/
154 src/Compiler/
230 vsintegration/src/
This is about 50:
1 tests/FSharp.Compiler.ComponentTests/Diagnostics/
1 tests/FSharp.Compiler.ComponentTests/Miscellaneous/
1 tests/FSharp.Compiler.ComponentTests/OCamlCompat/
1 tests/fsharp/conformance/
1 tests/fsharp/perf/
2 tests/FSharp.Compiler.ComponentTests/TypeChecks/
2 tests/FSharp.Compiler.ComponentTests/resources/
2 tests/fsharp/SDKTests/
2 tests/fsharp/tools/
2 vsintegration/src/FSharp.UIResources/
3 tests/FSharp.Compiler.ComponentTests/FSharpChecker/
4 src/Compiler/DependencyManager/
4 src/Compiler/SyntaxTree/
4 tests/FSharp.Compiler.ComponentTests/CompilerOptions/
5 src/Compiler/Facilities/
5 src/Compiler/Symbols/
5 tests/FSharp.Compiler.ComponentTests/Interop/
6 tests/FSharp.Compiler.ComponentTests/ErrorMessages/
About 55:
7 src/Compiler/Interactive/
7 src/Compiler/xlf/
7 tests/fsharp/Compiler/
7 vsintegration/src/FSharp.ProjectSystem.FSharp/
8 tests/fsharp/typeProviders/
8 vsintegration/tests/Salsa/
9 src/Compiler/Utilities/
58
10 src/Compiler/Optimize/
11 src/Compiler/CodeGen/
12 vsintegration/src/FSharp.LanguageService/
12 vsintegration/src/FSharp.VS.FSI/
13 src/Compiler/Driver/
104
13 tests/FSharp.Compiler.ComponentTests/Language/
13 tests/fsharp/regression/
14 src/Compiler/TypedTree/
14 tests/fsharp/typecheck/
15 tests/FSharp.Compiler.ComponentTests/EmittedIL/
16 vsintegration/src/FSharp.LanguageService.Base/
17 src/Compiler/Service/
75
18 tests/FSharp.Compiler.ComponentTests/Signatures/ 19 src/Compiler/AbstractIL/ 19 tests/fsharpqa/testenv/ 19 vsintegration/tests/FSharp.Editor.Tests/
101
26 vsintegration/tests/MockTypeProviders/ 30 vsintegration/src/FSharp.Editor/ 45 vsintegration/src/FSharp.ProjectSystem.PropertyPages/
55 src/Compiler/Checking/ 59 tests/FSharp.Compiler.ComponentTests/Conformance/ 70 vsintegration/tests/UnitTests/ 75 tests/fsharpqa/Source/ 99 tests/fsharp/core/
Probably too big:
133 vsintegration/src/FSharp.ProjectSystem.Base/
</details>
Oops sorry for a few non-applicable comments, was looking at the wrong place.
btw, re https://github.com/dotnet/fsharp/pull/16212#issuecomment-1802196033 you're absolutely right, VS Code's PR extension is wonderful for this stuff -- thanks for the suggestion!
The only thing I've tripped on is that it doesn't handle renames well (I filed a ticket for it).
I expect to need to cherry-pick 4a5ca4b89902ed2dd4673cec1a5355fac4bdf24d again (possibly fixed up), but this is effectively a rebase of everything else along with iterating over check-spelling's output again.
I should note that spell-check-this (the compendium ruleset to check-spelling) has gotten a bit more clever since I last worked on this repository, so it's now complaining about things like a an or the a as well as it's own.