fsharp icon indicating copy to clipboard operation
fsharp copied to clipboard

reporting unnamed fields in an FCS helper function

Open smoothdeveloper opened this issue 2 years ago • 2 comments

first bit of proof of concept for #15665

note to self: https://github.com/dotnet/fsharp/pull/14055 for reference of fixers dealing with DU fields.

I'm not clear if there are other things that could be checked, maybe we'd like to report bindings that are deconstructing types in function signatures; but this doesn't feel like an idiom to discourage (to me).

  • [x] report DU case fields
  • [x] report Exception fields

smoothdeveloper avatar Jul 22 '23 15:07 smoothdeveloper

Hi @smoothdeveloper, are you still interested in tackling this PR? :)

psfinaki avatar Jan 17 '24 12:01 psfinaki

This is available as an analyzer at https://ionide.io/ionide-analyzers/suggestion/004.html. I would not pursue to have this in the compiler.

nojaf avatar Feb 07 '24 09:02 nojaf

Closing since the same functionality is already available as an analyzer

abonie avatar Aug 12 '24 17:08 abonie