efcore icon indicating copy to clipboard operation
efcore copied to clipboard

Feature/translate json functions #29306

Open joelmandell opened this issue 3 years ago • 1 comments

Fixes #29306

  • [x] I've read the guidelines for contributing and seen the walkthrough
  • [x] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • [x] The code builds and tests pass locally (also verified by our automated build checks)
  • [ ] Commit messages follow this format: (This I totally forgot)
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Code follows the same patterns and style as existing code in this repo (Kinda... little bit different with unit-tests. But want to get your feedback if that's okay).

joelmandell avatar Jan 09 '23 23:01 joelmandell

json_value in differents rdbms:

mysql: https://dbfiddle.uk/?rdbms=mysql_8.0&fiddle=591207ceddca6fe4f11a3ad8589e7c5b sqlserver: https://dbfiddle.uk/?rdbms=sqlserver_2017&fiddle=5c70245f5bb7c96d4adcc6b10ebed195 postgres: https://dbfiddle.uk/o46x7dyL sqlite: https://www.db-fiddle.com/f/tMcVDVmjxb5wSjemg34dy8/2

celsowm avatar Jun 25 '23 23:06 celsowm

@roji I know I was late to the party and missed to tag you in to this before feature freeze for 8.0... Do you have any advice or comments on how I can move forward with this one to perhaps get it ready for 9.0? I can as well look into the other requests for json functions if possible.

joelmandell avatar Nov 12 '23 12:11 joelmandell

@joelmandell sure thing - I'd also definitely like us to get this in for 9.0.

Here's my advice... Give us around a month, maybe a bit more to deal with the 8.0 release and the subsequent patching and other work - and then ping me here again. Assuming it's a good time to iterate on it, you can then rebase this PR on the latest main, and then we can get this to completed state and merge.

roji avatar Nov 12 '23 12:11 roji

Ping @roji. I do not know if it is to early to continue on this one now? :)

joelmandell avatar Jan 03 '24 16:01 joelmandell