docs-aspire icon indicating copy to clipboard operation
docs-aspire copied to clipboard

Non AZD Azure deployment article is out of date

Open davidfowl opened this issue 1 year ago • 8 comments

https://learn.microsoft.com/en-us/dotnet/aspire/deployment/azure/aca-deployment?tabs=visual-studio%2Cinstall-az-windows%2Cpowershell&pivots=azure-bicep

https://learn.microsoft.com/en-us/dotnet/aspire/deployment/azure/aca-deployment?tabs=visual-studio%2Cinstall-az-windows%2Cpowershell&pivots=azure-cli

  • It uses the template with http+https scheme now which means service discovery information needs to be set

cc @bradygaster @DamianEdwards

davidfowl avatar Apr 26 '24 14:04 davidfowl

cc @alexwolfmsft who is working on the deployment doc updates now. We toyed with - and like - the idea of completely removing the az cli section. Any objections, @davidfowl and @DamianEdwards?

bradygaster avatar Apr 26 '24 15:04 bradygaster

cc @alexwolfmsft who is working on the deployment doc updates now. We toyed with - and like - the idea of completely removing the az cli section. Any objections, @davidfowl and @DamianEdwards?

We also proposed either removing the Bicep section or reducing it down to an overview and linking out to a sample repo that includes the finalized bicep scripts to avoid copy/pasting large blocks of text.

alexwolfmsft avatar Apr 26 '24 15:04 alexwolfmsft

I think we should remove them as well. Hand rolling what azd does is kinda painful 😄. @DamianEdwards ?

davidfowl avatar Apr 26 '24 15:04 davidfowl

The only reason for keeping it I think would be that it helps to explain all that is being automated by azd. This could be useful for folks who aren't ready/willing to adopt azd for deployment but are using bicep and/or az as this make it pretty clear what's involved.

DamianEdwards avatar Apr 26 '24 17:04 DamianEdwards

Then someone needs to validate these manual steps every release.

davidfowl avatar Apr 26 '24 19:04 davidfowl

Then someone needs to validate these manual steps every release.

Not it! 🥸

IEvangelist avatar May 17 '24 12:05 IEvangelist

The article doesn't seem to actually contain details for deploying with az or bicep anymore, despite what the introduction paragraph says. Am I missing something?

DamianEdwards avatar May 17 '24 14:05 DamianEdwards

The article doesn't seem to actually contain details for deploying with az or bicep anymore, despite what the introduction paragraph says. Am I missing something?

Yeah, there's been a lot of recent changes around deployment. Lots of moving parts, looks like this article is now only focusing on azd but the intro wasn't updated.

IEvangelist avatar May 17 '24 20:05 IEvangelist

This was closed in 8d87fe7.

IEvangelist avatar May 30 '24 12:05 IEvangelist

@vhvb1989 can we document the way parameters work in this article ?

davidfowl avatar May 30 '24 13:05 davidfowl