deployment-tools icon indicating copy to clipboard operation
deployment-tools copied to clipboard
verified publisher icon dotnet

Dev/issue 237

Open jwwise-best opened this issue 1 year ago • 1 comments

This addresses the folder not found issue.

jwwise-best avatar Apr 03 '24 19:04 jwwise-best

@dotnet-policy-service agree

jwwise-best avatar Apr 03 '24 19:04 jwwise-best

@jwwise-best is this needed in 8.0 servicing? Should this PR target main instead?

NikolaMilosavljevic avatar May 13 '24 16:05 NikolaMilosavljevic

The fix was developed against 8.0 but should apply to all later versions as well. I would target main, but it is behind the release and I did not want to contaminate the main branch with other release changes, and allow the merge back process to handle getting it back to main. How would you like me to proceed? Apply the change to main or leave this PR alone?

jwwise-best avatar May 23 '24 14:05 jwwise-best

The fix was developed against 8.0 but should apply to all later versions as well. I would target main, but it is behind the release and I did not want to contaminate the main branch with other release changes, and allow the merge back process to handle getting it back to main. How would you like me to proceed? Apply the change to main or leave this PR alone?

Yeah, we don't want to bring any other changes from your branch. If you could cherry-pick this commit into a new branch and create a new PR for main, we could get this merged quickly.

NikolaMilosavljevic avatar May 23 '24 16:05 NikolaMilosavljevic

abandoning this PR for the updated one: https://github.com/dotnet/deployment-tools/pull/365

jwwise-best avatar May 23 '24 17:05 jwwise-best