aspire icon indicating copy to clipboard operation
aspire copied to clipboard
verified publisher icon dotnet

Set assembly metadata with build configuration for AppHost and apply to projects in CLI mode

Open danegsta opened this issue 2 years ago • 6 comments

Microsoft Reviewers: Open in CodeFlow

danegsta avatar Apr 25 '24 23:04 danegsta

@danegsta is this PR stale? should it be closed?

joperezr avatar May 16 '24 15:05 joperezr

@joperezr this is likely stale at this point; did we get a different workaround for the release mode problem merged?

danegsta avatar May 16 '24 17:05 danegsta

I believe so but not 100% sure, I thought @mitchdenny came up with a different fix? I can test real quick

joperezr avatar May 16 '24 17:05 joperezr

Just tested this and it is in fact not yet fixed. Looks like this is one thing we'll want to take for 8.1. There was some conversation in chat around using special attributes, assuming all of the feedback is already incorporated with this PR?

joperezr avatar May 16 '24 18:05 joperezr

Yeah, it's been updated to honor the built-in AssemblyConfigurationAttribute the SDK applies, rather than rolling our own assembly attribute via targets.

danegsta avatar May 16 '24 18:05 danegsta

I'll merge main into the PR branch to kick off a fresh build, just to make sure nothing has drifted far enough to cause issues since the last build.

danegsta avatar May 16 '24 18:05 danegsta