Silk.NET icon indicating copy to clipboard operation
Silk.NET copied to clipboard

Adding DirectComposition to Silk

Open curin opened this issue 3 years ago • 1 comments

Adding Microsoft's DirectComposition Library to Silk as another supported library.

curin avatar Aug 03 '22 01:08 curin

CLA assistant check
All CLA requirements met.

dnfadmin avatar Aug 03 '22 01:08 dnfadmin

Is this still active?

Perksey avatar Nov 03 '22 12:11 Perksey

Direct Composition requires Direct2D, so this got put on hold until Direct2D was merged.

curin avatar Nov 03 '22 14:11 curin

Ah yeah right, forgot about that.

Perksey avatar Nov 03 '22 14:11 Perksey

@curin Pinging to let you know Direct2D has been merged, so if you would like to go forward with this PR, you should be able to rebase and force push

Beyley avatar Nov 24 '22 07:11 Beyley

Thanks for the reminder, I might have time to get to it today.

curin avatar Nov 24 '22 14:11 curin

This should be all set now

curin avatar Nov 27 '22 00:11 curin

Could you rebase and attempt to regenerate again? there seems to be some missing symbols and its causing CI to fail, also if possible (aka if its a reasonable amount of code, dw about it if itd take a few thousand lines of code and requires something like D3D to work), could you write a small example app in the src/Lab/ folder? I'm not well versed enough in any of the DirectX things aside from Direct3D to be able to write my own example for this

Beyley avatar Nov 30 '22 19:11 Beyley

I'll rebase and attempt to regenerate, see if I can fix the CI issues. As for an example, DirectComposition is used for compositing multiple render targets and interacting with Windows (for some indirect drawing techniques). Unfortunately, that means it requires either d3d or d2d to build on top of. I do want to get an example running, but I don't know if I'll be able to at the moment. If I get the time this weekend, I'll attach it to this PR, otherwise I don't want to push this out necessarily.

curin avatar Nov 30 '22 21:11 curin

I'll rebase and attempt to regenerate, see if I can fix the CI issues. As for an example, DirectComposition is used for compositing multiple render targets and interacting with Windows (for some indirect drawing techniques). Unfortunately, that means it requires either d3d or d2d to build on top of. I do want to get an example running, but I don't know if I'll be able to at the moment. If I get the time this weekend, I'll attach it to this PR, otherwise I don't want to push this out necessarily.

Understandable if it takes time, feel free to delay it to after this PR is merged, a second PR adding an example if nessesary would be good.

Beyley avatar Nov 30 '22 21:11 Beyley

So this commit was getting a clean compile on my end. Gonna be honest, I completely forgot about compiling the last update XD We should be all good to go. I didn't rebase it to absolute latest but I assume there shouldn't be any conflicts.

curin avatar Dec 06 '22 01:12 curin

I dont think what i brought up is a hard blocker, but the naming issues are a bit concerning

Beyley avatar Dec 07 '22 00:12 Beyley

@Beyley can you approve this please

Perksey avatar Jan 21 '23 20:01 Perksey