LLVMSharp icon indicating copy to clipboard operation
LLVMSharp copied to clipboard

Suggestion to enhance parameter names

Open TChatzigiannakis opened this issue 10 years ago • 1 comments

Most of the method signatures look something like this (matching the C++ API names verbatim):

public Instruction CreateArrayMalloc(Type @Ty, Value @Val, string @Name)

They could be changed to match the .NET naming convention:

public Instruction CreateArrayMalloc(Type ty, Value val, string name)

Or further, to something more descriptive like:

public Instruction CreateArrayMalloc(Type allocatedType, Value array, string name)

Does any of the two sound good (and which one)? If so, in future commits I may start converting some of the signatures as I go, if that's okay.

TChatzigiannakis avatar Aug 09 '15 06:08 TChatzigiannakis

I prefer the first one, i.e. lower casing the C++ names. The reason is that as we can still automate additions.

And yes I think it's fine moving to that style

mjsabby avatar Aug 10 '15 17:08 mjsabby