HttpRepl icon indicating copy to clipboard operation
HttpRepl copied to clipboard

Revisit command-specific telemetry implementations

Open tlmii opened this issue 5 years ago • 0 comments

In discussions with @jimmylewis about the changes necessary to make #430 work, there's agreement that the current need for an ITelemetry object to be passed into every command that needs specific info (in this case BaseHttpCommand-derived commands) is far from ideal.

But the current infrastructure of ICommand<> -> CommandWithStructuredBase<> -> BaseHttpCommand makes implementing a proper decorator pattern infeasible at this late stage.

Further, we're likely to be changing much of that infrastructure based on the System.CommandLine work, which may make this moot, easier or just different.

This issue is here to track the technical debt and make sure we address it later as that System.CommandLine work comes alive.

tlmii avatar Nov 10 '20 00:11 tlmii