questions to help with future PRs
-
DotNetCliExecutorusesSynchronousProcessOutputLoggerWithDiagnoser, which reads stdout (only) synchronously, and once it getsAfterAllsignal, it stops reading. But this means that we miss any output after that line, which could be some error messages. And these can be helpful if, say, the process didn't quit in the 2s after this.- Would it be acceptable to make this similar to
AsyncProcessOutputReader, such that you have aProcessInput(exitTimeout), which continues to read the output for 2s afterAfterAll, and then returns? - Or maybe refactor a bit to use AsyncProcessOutputReader instead (+message processing)?
- Would it be acceptable to make this similar to
-
~I want to add support for showing build output, for long running builds like wasm AOT. Should I plumb that as
--showBuildOutputtoConfigOptions.ShowBuildOutput, and then through the call chain to the output readers? Or would it be fine to maybe add a environment variable to control this?~ -
If a build fails, then we try again with
--no-dependencies. Why is that? That can hide issues, and cause incorrect builds to be run. If it's needed, then it might be useful to add an option to skip it, not via command line but when defining the toolchain.
cc @adamsitnik