dotnet
Added article: SignalR with Open AI
Internal previews
| 📄 File | 🔗 Preview link |
|---|---|
| aspnetcore/tutorials/ai-powered-group-chat/ai-powered-group-chat.md | aspnetcore/tutorials/ai-powered-group-chat/ai-powered-group-chat |
@kevinguo-ed please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@dotnet-policy-service agree [company="{your company}"]Options:
- (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
- (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"Contributor License Agreement
@dotnet-policy-service agree company="Microsoft"
I don't think this content really works as a tutorial. This is more an explanation of the sample project. Can you move this down to the Samples section?
I agree with both of Mike's points above.
@BrennanConroy This looks like the sample itself from https://github.com/microsoft/SignalR-Samples-AI/tree/main/AIStreaming would be a candidate to go here with the existing SignalR samples: https://github.com/aspnet/SignalR-samples
Then per Mike's point above, the content for that sample in this PR here (after another edit round which I will help with) would go in a README for the sample. It is more of a description of the sample, rather than a tutorial.
Thoughts?
I don't think this content really works as a tutorial. This is more an explanation of the sample project. Can you move this down to the Samples section?
(I've been assigned to finish this up.)
Thanks @mikekistler , you mentioned moving this down to the "Samples section"
I assume you meant moving it down in the TOC menu to "Real-time apps > Samples "
...that points directly to the sample repo here. https://github.com/aspnet/SignalR-samples
Were you thinking the content in this PR should move to the SignalR-samples repo, or were you envisioning sub links under the Real-time apps > Samples TOC? If the latter, then I will create two sub items to "Samples" in the TOC, one for the samples repo (and make it more clear that is where it points to) and another for this topic.
Also, The code sample for the doc in the PR is located here: https://github.com/microsoft/SignalR-Samples-AI/tree/main/AIStreaming
It is not clear to me if the intent was that the samples code for this topic stays in that repo. I'm unaware of the history on that. I'll assume it does rather than moving it to the sample to the SignalR-samples repo unless I hear otherwise.
Thanks for any clarification.
Moving this to the SignalR-samples repo was what I had in mind, but sadly that repo is archived now, so we probably need some other solution. I don't have any strong opinion on this -- only that we should differentiate tutorials and samples for the benefit of users.
Closing this PR since commits were merged through a new one.
The commits here were moved into a new PR by request, which included all changes asked for at the time, plus some updates per review at https://github.com/dotnet/AspNetCore.Docs/pull/34848 and that merged after approval.
However, I didn't realize that two more suggestions were made on this PR just before I merged to main.
- @IEvangelist, I added your suggested StringBuilder link just now with #35029
- @BrennanConroy, for: "nit: This is something I don't like about Bing chat, it sends the entire message every update. Really it should just append the new content on the client side". It wasn't clear to me if there was an design change to be made here in the example to accommodate the problem, in which case I will create a new issue for it, or if you were just noting a Bing chat design problem, no sample change needed.