AspNetCore.Docs icon indicating copy to clipboard operation
AspNetCore.Docs copied to clipboard

IsLockedOut has a different meaning than LockoutEnabled.

Open KeesAlderliesten opened this issue 3 years ago • 5 comments

[Enter feedback here]

IsLockedOut has a different meaning than LockoutEnabled. IsLockedOut is set if a user had too many failed logins. If LockoutEnabled is set then a user can be locked out with too many failed attempts (resulting in LockoutEnd being set to a date in the future). If LockoutEnabled is false then a user is never locked out.

So, migrating IsLockedOut to LockedoutEnabled makes no sense.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

KeesAlderliesten avatar Sep 05 '22 17:09 KeesAlderliesten

@haok please review.

Rick-Anderson avatar Sep 30 '22 03:09 Rick-Anderson

Since I don't believe membership had the ability to toggle this on or off per user. I think its probably better to just change it to set LockoutEnabled to true as part of this migration

HaoK avatar Sep 30 '22 16:09 HaoK

@KeesAlderliesten Thanks for reporting this. Any chance you could PR this? At the top right of the article, select the Edit pen icon:

image

Select the pen icon again. Save.

Rick-Anderson avatar Sep 30 '22 17:09 Rick-Anderson

I edited the article but I’m not sure I did it correctly, I don’t see my changes anymore…

Kind regards,

Kees Alderliesten

[Beschrijving: Frames Logo 2011 200]

Bourgondischelaan 30e 2983 SH Ridderkerk The Netherlands Tel +31-180-849446 www.frames.nlhttp://www.frames.nl/

Van: Rick Anderson @.> Verzonden: vrijdag 30 september 2022 19:50 Aan: dotnet/AspNetCore.Docs @.> CC: Kees Alderliesten | Frames automatisering bv @.>; Mention @.> Onderwerp: Re: [dotnet/AspNetCore.Docs] Error in documentation (Issue #26932)

@KeesAlderliestenhttps://github.com/KeesAlderliesten Thanks for reporting this. Any chance you could PR this? At the top right of the article, select the Edit pen icon:

[image]https://user-images.githubusercontent.com/3605364/53368931-11972200-38ee-11e9-86ce-18aaff69c719.png

Select the pen icon again. Save.

— Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetCore.Docs/issues/26932#issuecomment-1263851485, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB6MVIS7LZXHAVWBS3OFBQ3WA4R3DANCNFSM6AAAAAAQFFXF6Q. You are receiving this because you were mentioned.Message ID: @.@.>>

KeesAlderliesten avatar Oct 21 '22 07:10 KeesAlderliesten

I edited the article but I’m not sure I did it correctly, I don’t see my changes anymore…

Try again, it will offer to make a PR.

Rick-Anderson avatar Oct 21 '22 18:10 Rick-Anderson

@KeesAlderliesten can you try again. It will create a new branch for you and a PR.

Rick-Anderson avatar Jan 19 '23 02:01 Rick-Anderson

@tdykstra see image

Rick-Anderson avatar Jan 31 '23 23:01 Rick-Anderson

Sorry, I missed that, reverting assignment.

tdykstra avatar Jan 31 '23 23:01 tdykstra