graphql-code-generator icon indicating copy to clipboard operation
graphql-code-generator copied to clipboard

test: Added a test that fails when a folder contains the equals sign

Open maarekj opened this issue 2 years ago • 2 comments

Add a test for verify the issue https://github.com/dotansimha/graphql-code-generator/issues/8978

Description

There is a bug with the generator when there is an equals sign in a folder name. All files inside the folder are ignored. This PR adds a test (which currently fails), to verify that these files are not skipped

Related #8978

Type of change

Please delete options that are not relevant.

  • [x] Add test for a bug
  • [ ] Fix the bug

Checklist:

  • [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

maarekj avatar Feb 14 '23 08:02 maarekj

⚠️ No Changeset found

Latest commit: e897e5bd9e54fd46c9021c8190e7577ab99d4693

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 14 '23 08:02 changeset-bot[bot]

I think this RegExp needs to be updated https://github.com/ardatan/graphql-tools/blob/master/packages/utils/src/helpers.ts#L28

ardatan avatar Feb 14 '23 09:02 ardatan