Donald Sharp

Results 346 comments of Donald Sharp

The path generated is selected by the operators configure statement, here's our line in the frr.service: PIDFile=@e_frr_runstatedir@/watchfrr.pid This is generated from the configure.ac option of `--local-state-dir=XXX`. Since I have absolutely...

can we fix the commit message to say `tests: stabilize bgp_peergroup_gshut test case`

Looks like frrbot and verify source are finding some issues that need to be cleaned up in the commit. Please take a second and do so.

Can we also rewrite the commit message to first discuss the code change and then the topotest change especially in more detail. When I started looking at the subject line...

I hate this one. Thinking about it some more

I rewrote the whole approach. I like this better

Hey why was this put in? Mark had reservations that were not answered

As discussed in the maintainers channel w/ Phillippe:

do we have other timers that are 0-X and 0 means run it immediately? In other words do we need to go through and make our behavior consistent for all...

PBR is designed to work with an incoming interface, if you do not want that we will need to modify PBR to do this.