Dominik Lander

Results 29 comments of Dominik Lander

Oh I thought the user's preferred edition cookie wasn't available server-side as it goes through Fastly. If we can access that cookie server-side then those problems go away!

Good news, we _can_ access that cookie server-side 🙌 This does mean that users with the "hide the banner" cookie will see a flash of content, as the banner will...

Blocked: waiting for Identity & Trust team to respond to cookie request.

> Just to note that I've experienced a bug with this banner this morning on Chrome on my Android phone? It seems to be unduly persistent on https://www.theguardian.com/uk - I'm...

A similar task was completed in the mobile apps article templates project https://github.com/guardian/mobile-apps-article-templates/pull/1372/files

Does [ViewTransitions](https://github.com/guardian/guardian-engineering-site/blob/main/src/layouts/page.astro#L33) need to be replaced with ClientRouter? https://docs.astro.build/en/guides/upgrade-to/v5/#renamed-viewtransitions--component

The icon and text "Notifications off" doesn't fit in the left column at the `left-col` breakpoint as it stands. I spoke to Harry F and he suggests removing the right-margin...

Unassigning myself as anyone can pick this up

Superseded by https://github.com/guardian/dotcom-rendering/pull/15029