dokku
Un-hardcode the master branch in plugin updates
Fixes #71
My experience with Go is minimal, and I wasn't able to get the go-bindata generated code to create a reasonable diff, ~~so I did not include that.~~ It's included as a separate commit.
Do you mind adding a unit test? I've created a main branch on the smoke-test-plugin here.
Tests are available here: https://github.com/dokku/plugn/blob/master/tests/functional/tests.sh.
I'll take a look and see if we can replace go-bindata with go:embed, which should make developing easier.
I'll get right on that.
Although, that plugin won't be effective to test this. It's not the existence of main that's the issue, but the absence of master.
On Tue, Mar 26, 2024, 5:09 PM Jose Diaz-Gonzalez @.***> wrote:
Do you mind adding a unit test? I've created a main branch on the smoke-test-plugin here https://github.com/dokku/smoke-test-plugin/tree/main.
Tests are available here: https://github.com/dokku/plugn/blob/master/tests/functional/tests.sh.
I'll take a look and see if we can replace go-bindata with go:embed, which should make developing easier.
— Reply to this email directly, view it on GitHub https://github.com/dokku/plugn/pull/141#issuecomment-2021479369, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2AQKUID4SC3UWJ2XBASO3Y2HPZLAVCNFSM6AAAAABFJTYXMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRRGQ3TSMZWHE . You are receiving this because you authored the thread.Message ID: @.***>
I created the plugin here: https://github.com/dokku/smoke-test-plugin-main
Mind updating tests to use this branch?