dokku-postgres icon indicating copy to clipboard operation
dokku-postgres copied to clipboard

:art: Use the properties system instead of the service root

Open Schlepptop opened this issue 5 years ago • 4 comments

Schlepptop avatar Jul 16 '20 13:07 Schlepptop

General comment: we'll need to handle migration of the existing variables to the new properties system.

josegonzalez avatar Jul 16 '20 14:07 josegonzalez

Would that be fitting to do in the install file? Or isn't that used during updates?

Schlepptop avatar Jul 16 '20 16:07 Schlepptop

Maybe update - can you check what trigger we use in the plugin:update calls? - though we might need to do both - I think plugin:install is more or less plugin:update...

josegonzalez avatar Jul 16 '20 19:07 josegonzalez

They can be different, plugn calls the install hooks for install and update for update, but with update just being a link to install in this plugin, they really are the same.

Schlepptop avatar Jul 17 '20 10:07 Schlepptop