dojo icon indicating copy to clipboard operation
dojo copied to clipboard

[torii] `--events-chunk-size` infinite loop

Open notV4l opened this issue 1 year ago • 5 comments

Describe the bug On my world, calling torii with --events-chunk-size & any value under 7 cause torii to infinite loop call starknet_getEvents Probly introduced with #1688

notV4l avatar Mar 31 '24 14:03 notV4l

i cant reproduce this issue. i dont think its associated with #1688 as the PR hasn't been merged yet

Larkooo avatar Apr 01 '24 14:04 Larkooo

i cant reproduce this issue. i dont think its associated with #1688 as the PR hasn't been merged yet

yes glihm noticed me it's not merged yet, i had issue with alpha-10

notV4l avatar Apr 01 '24 14:04 notV4l

i cant reproduce this issue. i dont think its associated with #1688 as the PR hasn't been merged yet

yes glihm noticed me it's not merged yet, i had issue with alpha-10

i think it's an issue with the get_events api

Larkooo avatar Apr 01 '24 14:04 Larkooo

for me it happens when i set the --events-chunk-size value to 1. it breaks the get_events api. for now maybe just try to not use that value. does it happen with other values than 1 for you?

Larkooo avatar Apr 01 '24 14:04 Larkooo

for me it happens when i set the --events-chunk-size value to 1. it breaks the get_events api. for now maybe just try to not use that value. does it happen with other values than 1 for you?

Will check on lower layers for that to ensure it's something that can be addressed. Thanks for investigating, we don't usually use 1 yes so lower priority than other fixes. :+1:

glihm avatar Apr 02 '24 13:04 glihm

iirc it has been changed on Torii. Can be re-open if necessary.

glihm avatar Jun 19 '24 21:06 glihm