dojo icon indicating copy to clipboard operation
dojo copied to clipboard

feat(torii): integrate long poll getTransactions

Open Larkooo opened this issue 1 year ago • 1 comments

closes DOJ-269 closes #1363

use the toriI_getTransactions long poll api when using katana and fallback to getEvents

Larkooo avatar Mar 21 '24 21:03 Larkooo

Codecov Report

Attention: Patch coverage is 21.21923% with 672 lines in your changes are missing coverage. Please review.

Project coverage is 66.98%. Comparing base (af9cdf6) to head (47c8f10).

:exclamation: Current head 47c8f10 differs from pull request most recent head 8c1326f. Consider uploading reports for the commit 8c1326f to get more accurate results

Files Patch % Lines
crates/torii/core/src/provider/mod.rs 13.97% 468 Missing :warning:
crates/torii/core/src/engine.rs 33.83% 88 Missing :warning:
crates/katana/rpc/rpc-types/src/transaction.rs 9.09% 70 Missing :warning:
crates/torii/core/src/provider/provider.rs 2.50% 39 Missing :warning:
bin/torii/src/main.rs 0.00% 4 Missing :warning:
crates/torii/core/src/provider/http.rs 94.11% 2 Missing :warning:
crates/torii/core/src/provider/transport.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
- Coverage   70.29%   66.98%   -3.31%     
==========================================
  Files         315      299      -16     
  Lines       35850    32510    -3340     
==========================================
- Hits        25201    21778    -3423     
- Misses      10649    10732      +83     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 21 '24 21:03 codecov[bot]

Will close this for now. We will re-open if necessary. Interesting to keep torii using standard json rpc which is for now well optimized with the recent events.

glihm avatar Oct 31 '24 19:10 glihm