dojo icon indicating copy to clipboard operation
dojo copied to clipboard

feat(torii): update model members and table when same model is registered again

Open Larkooo opened this issue 1 year ago • 2 comments

fixes DOJ-120, #1268

Larkooo avatar Mar 06 '24 17:03 Larkooo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.09%. Comparing base (8bfd5ad) to head (3388030). Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1634   +/-   ##
=======================================
  Coverage   69.09%   69.09%           
=======================================
  Files         265      265           
  Lines       26859    26859           
=======================================
  Hits        18559    18559           
  Misses       8300     8300           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 06 '24 17:03 codecov[bot]

Maybe this is a temp fix? But I think one issue is if we update an existing model with a new member, all records would be lost for that model in the db. However, the record state onchain still exists. We may need to do a more sophisticated db migration based on what changes are made to an existing model (ie add/remove/update columns)

broody avatar Mar 07 '24 18:03 broody

Will close if favor of better migration generated on the model changes. @Larkooo please feel free to re-open if this is still needed anyway. 👍

glihm avatar Jun 18 '24 02:06 glihm