dojo icon indicating copy to clipboard operation
dojo copied to clipboard

Expose devnet endpoints

Open notV4l opened this issue 2 years ago • 9 comments

Is your feature request related to a problem? Please describe. To support argentX & braavos, katana should expose some http endpoints.

Describe the solution you'd like support /predeployed_accounts (GET) support /account_balance (GET) support /fee_token (GET) support /mint (POST)

Additional context Im not sure which of those methods are required/used. After testing some, /predeployed_accounts is called, but those accounts are not used Seems both argentX & braavos deploy there own accounts and fund it using /mint

the way tis handled in starknet-devnet-rs https://github.com/0xSpaceShard/starknet-devnet-rs/blob/e3c69015fa19f261487ea094caee2c72cdc3a64b/crates/starknet-devnet-server/src/server.rs#L44-L47

notV4l avatar Feb 26 '24 15:02 notV4l

That may actually be a good first issue, as the necessary implementations and types are here, and this should be placed under the dev RPC namespace of Katana: https://github.com/dojoengine/dojo/blob/main/crates/katana/rpc/rpc-api/src/dev.rs.

glihm avatar Jun 19 '24 22:06 glihm

@notV4l @glihm Can I work on this task?

PedroRosalba avatar Jun 26 '24 15:06 PedroRosalba

Hello @glihm I would like to work on this issue :D

fabrobles92 avatar Jul 10 '24 19:07 fabrobles92

Sorry guys for the delay on this one. @PedroRosalba if you're still around, please let's know. If not, @fabrobles92 will be assigned to you. 👍

glihm avatar Jul 10 '24 21:07 glihm

@fabrobles92, all yours!

glihm avatar Jul 17 '24 22:07 glihm

@glihm I am looking into this now and want to make sure I understand correctly what is needed here.

I have to add the following methods to the trait DevApi here: predeployed_accounts account_balance fee_token mint

Note. I am seeing that under crates/katana/rpc/rpc-api/src/katana.rs we already have a trait method called predeployed_accounts

Note 2. You mention that the necessary implementations and types are already in the code, I am trying to find them without luck, would you point me where are those?

Or I need to create a new endpoint somewhere with those routes?

fabrobles92 avatar Jul 20 '24 17:07 fabrobles92

Sorry @fabrobles92 I just totally missed that. Could we catch up during the week?

That's perfect under Dev api. 👍 @kariy do you confirm or should we do an other namespace for those RPC calls?

glihm avatar Aug 12 '24 23:08 glihm

Any update on that @fabrobles92?

glihm avatar Aug 29 '24 20:08 glihm

Currently looking into the implementations and types that already exist in code.

fabrobles92 avatar Sep 02 '24 20:09 fabrobles92

If this is still open, I'd like to step in

I was an early contributor to the Starknet community. After being disconnected for a few months, I’m eager to get back on track, and I’d like to work on this issue as a way to re-engage and contribute actively again.

Aside from that, I’m passionate about seeing Web3 gaming thrive, and I believe Dojo is the best project to make that vision a reality.

bigherc18 avatar Dec 13 '24 23:12 bigherc18