book icon indicating copy to clipboard operation
book copied to clipboard

feat(#261): add new folder with deployment commands and delete deploy…

Open juandiegocv27 opened this issue 1 year ago • 4 comments

This is the issue #261.

Just modified and add some features for Slot CLI documentation that will bring great context with:

-deleted deployments page. -added create, delete, update, describe, list, logs and help command pages.

image

@kariy.

juandiegocv27 avatar May 13 '24 05:05 juandiegocv27

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
book ✅ Ready (Inspect) Visit Preview Jul 19, 2024 0:06am

vercel[bot] avatar May 13 '24 05:05 vercel[bot]

Hi, @kariy I have an error, in this part, could you check it, I'll fix it as soon as possible

juandiegocv27 avatar May 13 '24 05:05 juandiegocv27

hey @juandiegocv27 thanks for the work!

can you also update the sidebar config so that the new pages would be accessible from the sidebar ?

Screenshot 2024-05-13 at 9 12 24 AM

Ok sure 🫡

juandiegocv27 avatar May 13 '24 15:05 juandiegocv27

Hi @kariy, I just fix it, and agreggate some features, hope for feedback

juandiegocv27 avatar May 13 '24 20:05 juandiegocv27

HI @kariy @milancermak, is this PR is still relevant? Please let me know if there's anything else you’d like me to add or if you have any feedback. I'm happy to make any changes you need. Thanks (plus: the check failed beacuse I erased the file that you recommend me to eliminate).

juandiegocv27 avatar May 28 '24 01:05 juandiegocv27

@juandiegocv27 could you fix the conflict

ponderingdemocritus avatar May 28 '24 05:05 ponderingdemocritus

@ponderingdemocritus sure, but, talking in discord with @kariy told me to erase the file deployments.md, so I could return it, but all that I do was put more stuff and make deployments a folder. Give me a moment and I'll return it hehe

juandiegocv27 avatar May 28 '24 05:05 juandiegocv27

@ponderingdemocritus @kariy @milancermak @ptisserand, just resolved conflicts, plus update the code to the last comit of dojo book

juandiegocv27 avatar May 29 '24 04:05 juandiegocv27

@ponderingdemocritus @kariy @milancermak @ptisserand Fix all the code and ready to merge: image

waiting for more feedback 😎🚀

juandiegocv27 avatar Jun 04 '24 07:06 juandiegocv27

Thanks for the work here @juandiegocv27!

Some important points:

  1. consistency: slot should be formatted with consistency as sometimes you use Slot and sometimes Slot.

  2. formatting: I've left some commands on formatting, not on all the lines that require changes, you may do a general review of formatting.

@glihm thanks a lot for the feedback, I'll work on it as fast as possible ⚡️

juandiegocv27 avatar Jun 11 '24 18:06 juandiegocv27

hI @glihm, @kariy, I fix somethings in this issue, ready to merge🚀

juandiegocv27 avatar Jul 16 '24 20:07 juandiegocv27

@juandiegocv27 thanks for the work here! Some comments that also apply to all commands.

Once done, this should be ready for merging! Thank you for the iterations, let's know if you have any question!

Thank you for the feedback @glihm, I´ll make the changes as fast as possible

juandiegocv27 avatar Jul 18 '24 17:07 juandiegocv27

@juandiegocv27 thanks for the work here! Some comments that also apply to all commands. Once done, this should be ready for merging! Thank you for the iterations, let's know if you have any question!

Thank you for the feedback @glihm, I´ll make the changes as fast as possible

No rush, thank you for your contribution. 👍

glihm avatar Jul 18 '24 21:07 glihm

@juandiegocv27 thanks for the work here! Some comments that also apply to all commands. Once done, this should be ready for merging! Thank you for the iterations, let's know if you have any question!

Thank you for the feedback @glihm, I´ll make the changes as fast as possible

No rush, thank you for your contribution. 👍

Already fix and put response and output in every command😎 @glihm

juandiegocv27 avatar Jul 19 '24 00:07 juandiegocv27

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

vercel[bot] avatar Jul 23 '24 13:07 vercel[bot]

lgtm

thank you so much

juandiegocv27 avatar Jul 24 '24 17:07 juandiegocv27