feat(#261): add new folder with deployment commands and delete deploy…
This is the issue #261.
Just modified and add some features for Slot CLI documentation that will bring great context with:
-deleted deployments page. -added create, delete, update, describe, list, logs and help command pages.
@kariy.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| book | ✅ Ready (Inspect) | Visit Preview | Jul 19, 2024 0:06am |
Hi, @kariy I have an error, in this part, could you check it, I'll fix it as soon as possible
hey @juandiegocv27 thanks for the work!
can you also update the sidebar config so that the new pages would be accessible from the sidebar ?
![]()
Ok sure 🫡
Hi @kariy, I just fix it, and agreggate some features, hope for feedback
HI @kariy @milancermak, is this PR is still relevant? Please let me know if there's anything else you’d like me to add or if you have any feedback. I'm happy to make any changes you need. Thanks (plus: the check failed beacuse I erased the file that you recommend me to eliminate).
@juandiegocv27 could you fix the conflict
@ponderingdemocritus sure, but, talking in discord with @kariy told me to erase the file deployments.md, so I could return it, but all that I do was put more stuff and make deployments a folder. Give me a moment and I'll return it hehe
@ponderingdemocritus @kariy @milancermak @ptisserand, just resolved conflicts, plus update the code to the last comit of dojo book
@ponderingdemocritus @kariy @milancermak @ptisserand Fix all the code and ready to merge:
waiting for more feedback 😎🚀
Thanks for the work here @juandiegocv27!
Some important points:
consistency:
slotshould be formatted with consistency as sometimes you useSlotand sometimes Slot.formatting: I've left some commands on formatting, not on all the lines that require changes, you may do a general review of formatting.
@glihm thanks a lot for the feedback, I'll work on it as fast as possible ⚡️
hI @glihm, @kariy, I fix somethings in this issue, ready to merge🚀
@juandiegocv27 thanks for the work here! Some comments that also apply to all commands.
Once done, this should be ready for merging! Thank you for the iterations, let's know if you have any question!
Thank you for the feedback @glihm, I´ll make the changes as fast as possible
@juandiegocv27 thanks for the work here! Some comments that also apply to all commands. Once done, this should be ready for merging! Thank you for the iterations, let's know if you have any question!
Thank you for the feedback @glihm, I´ll make the changes as fast as possible
No rush, thank you for your contribution. 👍
@juandiegocv27 thanks for the work here! Some comments that also apply to all commands. Once done, this should be ready for merging! Thank you for the iterations, let's know if you have any question!
Thank you for the feedback @glihm, I´ll make the changes as fast as possible
No rush, thank you for your contribution. 👍
Already fix and put response and output in every command😎 @glihm
Deployment failed with the following error:
The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.
lgtm
thank you so much