widgets icon indicating copy to clipboard operation
widgets copied to clipboard

1709 list item structure

Open tomdye opened this issue 5 years ago β€’ 2 comments

Type: bug / feature

The following has been addressed in the PR:

  • [ ] There is a related issue
  • [ ] All code matches the style guide
  • [ ] Unit tests are included in the PR
  • [ ] For new widgets, an entry has been added to the .dojorc
  • [ ] For new widgets, theme.variant() is added to the root domnode
  • [ ] Any widget variant uses theme.compose like this
  • [ ] WidgetProperties are exported

Description:

  • Changes list items to only put content in the primary span if typed children are used, this allows for full-width content to be passed.
  • adds padding property with specified sizes to ListItem to allow the padding to be easily reduced or increased.

Resolves #1709

tomdye avatar Mar 26 '21 17:03 tomdye

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

πŸ” Inspect: https://vercel.com/dojo/widget-test-docs/EYyzdnsyvfPEyWRTmgbvrFNJmugs
βœ… Preview: https://widget-test-docs-git-fork-tomdye-1709-list-item-structure-dojo1.vercel.app

dojo.widgets – ./

πŸ” Inspect: https://vercel.com/dojo/dojo.widgets/74fyTdUpkKX6KQt2HSggavsNXwGL
βœ… Preview: https://dojowidgets-git-fork-tomdye-1709-list-item-structure-dojo1.vercel.app

vercel[bot] avatar Mar 26 '21 17:03 vercel[bot]

Codecov Report

Merging #1710 (9ee7fe2) into master (650a556) will decrease coverage by 0.11%. The diff coverage is 65.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1710      +/-   ##
==========================================
- Coverage   90.07%   89.95%   -0.12%     
==========================================
  Files          94       94              
  Lines        5047     5059      +12     
  Branches     1375     1377       +2     
==========================================
+ Hits         4546     4551       +5     
- Misses        249      254       +5     
- Partials      252      254       +2     
Impacted Files Coverage Ξ”
src/list/index.tsx 78.61% <65.00%> (-1.33%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 650a556...9ee7fe2. Read the comment docs.

codecov[bot] avatar Mar 26 '21 17:03 codecov[bot]