1709 list item structure
Type: bug / feature
The following has been addressed in the PR:
- [ ] There is a related issue
- [ ] All code matches the style guide
- [ ] Unit tests are included in the PR
- [ ] For new widgets, an entry has been added to the
.dojorc - [ ] For new widgets,
theme.variant()is added to the root domnode - [ ] Any widget variant uses
theme.composelike this - [ ] WidgetProperties are exported
Description:
- Changes list items to only put content in the
primaryspan if typed children are used, this allows for full-width content to be passed. - adds
paddingproperty with specified sizes toListItemto allow the padding to be easily reduced or increased.
Resolves #1709
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
widget-test-docs β ./
π Inspect: https://vercel.com/dojo/widget-test-docs/EYyzdnsyvfPEyWRTmgbvrFNJmugs
β
Preview: https://widget-test-docs-git-fork-tomdye-1709-list-item-structure-dojo1.vercel.app
dojo.widgets β ./
π Inspect: https://vercel.com/dojo/dojo.widgets/74fyTdUpkKX6KQt2HSggavsNXwGL
β
Preview: https://dojowidgets-git-fork-tomdye-1709-list-item-structure-dojo1.vercel.app
Codecov Report
Merging #1710 (9ee7fe2) into master (650a556) will decrease coverage by
0.11%. The diff coverage is65.00%.
@@ Coverage Diff @@
## master #1710 +/- ##
==========================================
- Coverage 90.07% 89.95% -0.12%
==========================================
Files 94 94
Lines 5047 5059 +12
Branches 1375 1377 +2
==========================================
+ Hits 4546 4551 +5
- Misses 249 254 +5
- Partials 252 254 +2
| Impacted Files | Coverage Ξ | |
|---|---|---|
| src/list/index.tsx | 78.61% <65.00%> (-1.33%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact),ΓΈ = not affected,? = missing dataPowered by Codecov. Last update 650a556...9ee7fe2. Read the comment docs.