sacnview icon indicating copy to clipboard operation
sacnview copied to clipboard

Crash dumps are broken on Windows

Open marcusbirkin opened this issue 2 years ago • 1 comments

Breakpad isn't running the callback dumper for the Windows build, unsure from when but with at least v2.2.0-beta.1 From testing this appears to be only for Qt GUI apps; console apps work ok

Testing in release code is hampered by crash_test in v2.2.0-beta.1 not having suitable Qt6 callbacks as QSignalMapper::mapped was deprecated https://github.com/docsteer/sacnview/blob/bbe9ac0523f54792cff9963819fbcc5fc483fc0f/src/ui/crash_test.cpp#L23 Updated for Qt6 https://github.com/docsteer/sacnview/blob/107b8631caad7942c62b47ccc58678fa926644c7/src/ui/crash_test.cpp#L23

marcusbirkin avatar Mar 16 '23 09:03 marcusbirkin

Qt GUI is handling and absorbing all the normally "Unhandled" exceptions, meaning that the callback to create the minidumps from SetUnhandledExceptionFilter is never called.

Callbacks from AddVectoredExceptionHandler work, however this returns on all exceptions including those in a try-block. Breakpad does not include, out the box, support for vectored exception handler anyway.

I'm not sure how to resolve this one....

marcusbirkin avatar Mar 17 '23 17:03 marcusbirkin