docsify icon indicating copy to clipboard operation
docsify copied to clipboard

feat: collapse root sidsebar items

Open proke03 opened this issue 3 years ago • 5 comments

Summary

What kind of change does this PR introduce?

For any code change,

  • [ ] Related documentation has been updated if needed
  • [ ] Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

#900

Tested in the following browsers:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

proke03 avatar Jan 29 '23 08:01 proke03

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2023 10:27am

vercel[bot] avatar Jan 29 '23 08:01 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2daba85710d4a15cecaa01f661efe55d8f5e2987:

Sandbox Source
docsify-template Configuration

codesandbox-ci[bot] avatar Jan 29 '23 08:01 codesandbox-ci[bot]

@trusktr The themeable file is an extension of docsify. In themeable, style is specified. So, in order for changes in docsify to be applied without changing themeable, the id and class values previously specified in themeable must not be applied elsewhere. Is my understanding correct?

proke03 avatar Jul 20 '23 09:07 proke03

@proke03 basically the docsify-themeable CSS depends on the DOM of Docsify.

I think what we should do is in a totally separate pull request lets get a docsify-themeable deployment for n Vercel going, and then it will be available to all PR similar to our current Vercel deployment with vanilla Docsify.

trusktr avatar Jul 21 '23 01:07 trusktr