docsify icon indicating copy to clipboard operation
docsify copied to clipboard

fix: files from basePath should be remoteUrl:false

Open b6pzeusbc54tvhw5jgpyw8pwz2x6gs opened this issue 4 years ago • 2 comments

Summary

When using the basePath as an absolute url including the domain and the domain of index.html and the domain of basePath are different, Currently, files fetched from basePath are treated as isExternal: true , and I think this behavior is a bug.

basePath is a value that can be entered only with the authority of the document site administrator, and the basePath server can also be considered owned by the administrator, so the isRemoteUrl value should be false.

What kind of change does this PR introduce?

Bugfix

For any code change,

  • [ ] Related documentation has been updated if needed
  • [ ] Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

#1659

Tested in the following browsers:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/9PEsj4Y74qkJAhpihAttVtDSSv1y
✅ Preview: https://docsify-preview-git-fork-b6pzeusbc54tvhw5jg-bd121d-docsify-core.vercel.app

vercel[bot] avatar Nov 03 '21 12:11 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 16b5ba5e707e2108818a369ea729b6691941a822:

Sandbox Source
docsify-template Configuration

codesandbox-ci[bot] avatar Nov 03 '21 12:11 codesandbox-ci[bot]