docsify icon indicating copy to clipboard operation
docsify copied to clipboard

fix: ssr TypeError: Cannot read property 'indexOf' of undefined

Open jeffusion opened this issue 4 years ago • 7 comments

See this problem in issue: https://github.com/docsifyjs/docsify/issues/704

Summary

What kind of change does this PR introduce?

For any code change,

  • [ ] Related documentation has been updated if needed
  • [ ] Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

jeffusion avatar Aug 19 '21 07:08 jeffusion

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/6x5nWFyDtaarQUUPrdaQFT1BV7u3
✅ Preview: https://docsify-preview-git-fork-dysdf-fix-ssr-error-docsify-core.vercel.app

vercel[bot] avatar Aug 19 '21 07:08 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6428c84a418750974800ae73656d2969f5089b76:

Sandbox Source
docsify-template Configuration

codesandbox-ci[bot] avatar Aug 19 '21 07:08 codesandbox-ci[bot]

@trusktr @Koooooo-7 May I ask what is the status of this PR? Since it resolves a major issue that blocks the usage of SSR, I really hope it could be merged soon.

xiao99xiao avatar Aug 27 '21 16:08 xiao99xiao

@xiao99xiao Cause the SSR refactor has not set in place yet, it may be late to merge.

@trusktr do u think we could merge it as a patch for current SSR solution?

cc @docsifyjs/reviewers

Koooooo-7 avatar Sep 09 '21 10:09 Koooooo-7

Yeah, this is already fixed in my work. SSR is working, but not all things work yet. Namely we still need some special handling for plugins. Another issue I have is I haven't installed a VM for testing, the tests don't pass in my native OS. I will circle back again soon, i haven't forgotten!

trusktr avatar Sep 09 '21 16:09 trusktr

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docsify-preview ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 7:27AM (UTC)

vercel[bot] avatar Aug 23 '22 07:08 vercel[bot]

related pr

jeffusion avatar Aug 23 '22 09:08 jeffusion

see #2105

sy-records avatar Nov 18 '23 10:11 sy-records