docsify icon indicating copy to clipboard operation
docsify copied to clipboard

No docisfy.min.esm.js generated

Open jcayzac opened this issue 5 years ago • 2 comments

Bug Report

No docsify.esm.js or docsify.min.esm.js is generated by the build script although they're mentioned at:

https://github.com/docsifyjs/docsify/blob/da9af18c4e4aa8b2c42773a01104f5a7c0a628a4/src/core/global-api.js#L12

Modules have been supported by all browsers for 2 years. Please give us a module 😄

Steps to reproduce

curl https://unpkg.com/[email protected]/lib/docsify.esm.js

What is current behaviour

404 Not Found

What is the expected behaviour

200 OK

Other relevant information

  • [x] Bug does still occur when all/other plugins are disabled?

  • Your OS:

  • Node.js version:

  • npm/yarn version:

  • Browser version:

  • Docsify version: 4.11.6

  • Docsify plugins:

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

jcayzac avatar Dec 01 '20 06:12 jcayzac

Should be added in v5? @trusktr

// TODO This is deprecated, kept for backwards compatibility. Remove in next
// major release. We'll tell people to get everything from the DOCSIFY global
// when using the global build, but we'll highly recommend for them to import
// from the ESM build (f.e. lib/docsify.esm.js and lib/docsify.min.esm.js).

sy-records avatar Dec 01 '20 06:12 sy-records

@sy-records Adding this is a non-breaking change. We could add it any time.

For v4, it would still create globals (but also export the globals for convenience of importing). For v5, there would be no globals.

trusktr avatar Dec 31 '20 01:12 trusktr