docsify icon indicating copy to clipboard operation
docsify copied to clipboard

Added defaultFallbackLanguage config parameter [Close#916]

Open aemmadi opened this issue 5 years ago • 2 comments

Summary This PR closes #916 by making the request changes that weren't made in the original PR.

Added 'defaultFallbackLanguage' parameter to avoid the need of having the default language in root folder. This way we can have exactly formatted folders for each language including the default one without having to mix the default language with root files.

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [x] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • [ ] DO NOT include files inside lib directory.

aemmadi avatar Jul 08 '20 15:07 aemmadi

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/43tw4a6ja ✅ Preview: https://docsify-previe-git-fork-mlh-fellowship-default-fallback-469b62.docsify-core.vercel.app

vercel[bot] avatar Jul 08 '20 15:07 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 523e77f0cb9e7ad0af8a64991890fdf1948063ad:

Sandbox Source
docsify-template Configuration

codesandbox-ci[bot] avatar Jul 08 '20 15:07 codesandbox-ci[bot]